You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cxf.apache.org by se...@apache.org on 2014/07/03 13:38:32 UTC

git commit: Removing some comments from Lucene visitor

Repository: cxf
Updated Branches:
  refs/heads/master 1a6a69574 -> eafb1dc17


Removing some comments from Lucene visitor


Project: http://git-wip-us.apache.org/repos/asf/cxf/repo
Commit: http://git-wip-us.apache.org/repos/asf/cxf/commit/eafb1dc1
Tree: http://git-wip-us.apache.org/repos/asf/cxf/tree/eafb1dc1
Diff: http://git-wip-us.apache.org/repos/asf/cxf/diff/eafb1dc1

Branch: refs/heads/master
Commit: eafb1dc170408933038bd5ba444df9c67db18504
Parents: 1a6a695
Author: Sergey Beryozkin <sb...@talend.com>
Authored: Thu Jul 3 12:38:08 2014 +0100
Committer: Sergey Beryozkin <sb...@talend.com>
Committed: Thu Jul 3 12:38:08 2014 +0100

----------------------------------------------------------------------
 .../cxf/jaxrs/ext/search/lucene/LuceneQueryVisitor.java     | 9 ---------
 1 file changed, 9 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/cxf/blob/eafb1dc1/rt/rs/extensions/search/src/main/java/org/apache/cxf/jaxrs/ext/search/lucene/LuceneQueryVisitor.java
----------------------------------------------------------------------
diff --git a/rt/rs/extensions/search/src/main/java/org/apache/cxf/jaxrs/ext/search/lucene/LuceneQueryVisitor.java b/rt/rs/extensions/search/src/main/java/org/apache/cxf/jaxrs/ext/search/lucene/LuceneQueryVisitor.java
index 842c653..1f9dfda 100644
--- a/rt/rs/extensions/search/src/main/java/org/apache/cxf/jaxrs/ext/search/lucene/LuceneQueryVisitor.java
+++ b/rt/rs/extensions/search/src/main/java/org/apache/cxf/jaxrs/ext/search/lucene/LuceneQueryVisitor.java
@@ -44,7 +44,6 @@ import org.apache.lucene.search.WildcardQuery;
 
 public class LuceneQueryVisitor<T> extends AbstractSearchConditionVisitor<T, Query> {
 
-    //private Analyzer analyzer;
     private String contentsFieldName;
     private Map<String, String> contentsFieldMap;
     private Stack<List<Query>> queryStack = new Stack<List<Query>>();
@@ -92,10 +91,6 @@ public class LuceneQueryVisitor<T> extends AbstractSearchConditionVisitor<T, Que
             queryStack.peek().add(createCompositeQuery(queries, orCondition));
         }    
     }
-
-    //public void setAnalyzer(Analyzer a) {
-    //    this.analyzer = a;
-    //}
     
     public Query getQuery() {
         List<Query> queries = queryStack.peek();
@@ -189,8 +184,6 @@ public class LuceneQueryVisitor<T> extends AbstractSearchConditionVisitor<T, Que
         boolean maxInclusive = type == ConditionType.LESS_OR_EQUALS || type == ConditionType.EQUALS;
         
         if (String.class.isAssignableFrom(cls) || Number.class.isAssignableFrom(cls)) {
-            // If needed, long and double can be supported too
-            // Also, perhaps Strings may optionally be compared with string comparators 
             Query query = null;
             
             if (Double.class.isAssignableFrom(cls)) {
@@ -205,8 +198,6 @@ public class LuceneQueryVisitor<T> extends AbstractSearchConditionVisitor<T, Que
         
             return query;
         } else if (Date.class.isAssignableFrom(cls)) {
-            // This code has not been tested - most likely needs to be fixed  
-            // Resolution should be configurable ?
             final Date date = SearchUtils.dateFromStringWithContextProperties(value.toString());           
             final String luceneDateValue = (date != null) 
                 ? DateTools.dateToString(date, Resolution.MILLISECOND) : value.toString();