You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "Kaxil Naik (Jira)" <ji...@apache.org> on 2019/10/30 23:31:00 UTC
[jira] [Resolved] (AIRFLOW-5740) Fix Transient failure in Slack
test
[ https://issues.apache.org/jira/browse/AIRFLOW-5740?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kaxil Naik resolved AIRFLOW-5740.
---------------------------------
Resolution: Fixed
> Fix Transient failure in Slack test
> -----------------------------------
>
> Key: AIRFLOW-5740
> URL: https://issues.apache.org/jira/browse/AIRFLOW-5740
> Project: Apache Airflow
> Issue Type: Improvement
> Components: tests
> Affects Versions: 2.0.0
> Reporter: Kaxil Naik
> Priority: Major
> Fix For: 2.0.0
>
>
> Change Slack test so that it does Equality check regardless of order
> {noformat}
> 7) FAIL: test_build_slack_message (tests.contrib.hooks.test_slack_webhook_hook.TestSlackWebhookHook)
> ----------------------------------------------------------------------
> Traceback (most recent call last):
> File "/opt/airflow/tests/contrib/hooks/test_slack_webhook_hook.py", line 109, in test_build_slack_message
> self.assertEqual(self.expected_message, message)
> AssertionError: '{"ic[188 chars]k", "channel": "#general", "blocks": [{"type":[109 chars]: 1}' != '{"ic[188 chars]k", "username": "SlackMcSlackFace", "blocks": [109 chars]: 1}'
> - {"icon_emoji": ":hankey:", "icon_url": "https://airflow.apache.org/_images/pin_large.png", "attachments": [{"fallback": "Required plain-text summary"}], "text": "Awesome message to put on Slack", "channel": "#general", "blocks": [{"type": "section", "text": {"type": "mrkdwn", "text": "*bold text*"}}], "username": "SlackMcSlackFace", "link_names": 1}
> ? ^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> + {"icon_emoji": ":hankey:", "icon_url": "https://airflow.apache.org/_images/pin_large.png", "attachments": [{"fallback": "Required plain-text summary"}], "text": "Awesome message to put on Slack", "username": "SlackMcSlackFace", "blocks": [{"type": "section", "text": {"type": "mrkdwn", "text": "*bold text*"}}], "channel": "#general", "link_names": 1}
> ? ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)