[GitHub] [spark] maropu commented on a change in pull request #30496: [SPARK-33547][SQL] Add usage of typed literal in doc

[GitBox <gi...@apache.org>]

maropu commented on a change in pull request #30496:
URL: https://github.com/apache/spark/pull/30496#discussion_r531253301



##########
File path: docs/sql-ref-literals.md
##########
@@ -21,14 +21,74 @@ license: |
 
 A literal (also known as a constant) represents a fixed data value. Spark SQL supports the following literals:
 
+ * [Typed Literal](#typed-literal)
  * [String Literal](#string-literal)
  * [Binary Literal](#binary-literal)
  * [Null Literal](#null-literal)
  * [Boolean Literal](#boolean-literal)
  * [Numeric Literal](#numeric-literal)
+ * [Timestamp Literal](#timestamp-literal)
  * [Datetime Literal](#datetime-literal)
  * [Interval Literal](#interval-literal)
 
+### Typed Literal

Review comment:
       I feel "Typed Literal" is a bit confusing. For example, a numerical literal is also a typed literal, right? How about saying `Typed Literal for Binary, Date, Timestamp, and Interaval` instead?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org