[GitHub] [incubator-doris] morningman commented on a change in pull request #3305: Add field context for string field keyword type

[GitBox <gi...@apache.org>]

morningman commented on a change in pull request #3305: Add field context for string field keyword type
URL: https://github.com/apache/incubator-doris/pull/3305#discussion_r407062113
 
 

 ##########
 File path: be/src/exec/es/es_predicate.h
 ##########
 @@ -198,6 +198,10 @@ class EsPredicate {
         return _es_query_status;
     }
 
+    void field_context(const std::map<std::string, std::string>& field_context) {
 
 Review comment:
   better to call `set_ field_context`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org