You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sentry.apache.org by Arun Suresh <ar...@gmail.com> on 2014/12/15 10:41:07 UTC

Review Request 29042: SENTRY-567: SentryStore Decorator that adds Persistence to a given base SentryStore

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29042/
-----------------------------------------------------------

Review request for sentry, bc Wong, Lenni Kuff, Prasad Mujumdar, and Sravya Tirukkovalur.


Repository: sentry


Description
-------

This patch includes a base SentryStore Decorator (PersistentSentryStore) that can be used to log write operations on a SentryStore. This can be coupled with the InMemSentryStore to support Service restarts.
It patch also inclues an implementations (and associated testcases) for this Decorator
 1) SentryStoreWithFileLog logs all operations to a configured log directory. This is currently implemented as a write-behind log. it writes the entry to the log if the record has been successfully accepted by the backing SentryStore.

More decription on the JIRA : issues.apache.org/jira/browse/SENTRY-567


Diffs
-----

  sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/FileLog.java PRE-CREATION 
  sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/PersistentSentryStore.java PRE-CREATION 
  sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStoreWithFileLog.java PRE-CREATION 
  sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/persistent/TestFileLog.java PRE-CREATION 
  sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryStoreWithFileLog.java PRE-CREATION 

Diff: https://reviews.apache.org/r/29042/diff/


Testing
-------


Thanks,

Arun Suresh


Re: Review Request 29042: SENTRY-567: SentryStore Decorator that adds Persistence to a given base SentryStore

Posted by Arun Suresh <ar...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29042/
-----------------------------------------------------------

(Updated Dec. 18, 2014, 8:07 a.m.)


Review request for sentry, bc Wong, Lenni Kuff, Prasad Mujumdar, and Sravya Tirukkovalur.


Changes
-------

Updated with documenation


Repository: sentry


Description
-------

This patch includes a base SentryStore Decorator (PersistentSentryStore) that can be used to log write operations on a SentryStore. This can be coupled with the InMemSentryStore to support Service restarts.
It patch also inclues an implementations (and associated testcases) for this Decorator
 1) SentryStoreWithFileLog logs all operations to a configured log directory. This is currently implemented as a write-behind log. it writes the entry to the log if the record has been successfully accepted by the backing SentryStore.

To ensure that the log file does not grow indefinitely, It is periodically compacted by writing out a SentryStore snapshot.

More decription on the JIRA : issues.apache.org/jira/browse/SENTRY-567


Diffs (updated)
-----

  sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/FileLog.java PRE-CREATION 
  sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/PersistentSentryStore.java PRE-CREATION 
  sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStoreWithFileLog.java PRE-CREATION 
  sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/persistent/TestFileLog.java PRE-CREATION 
  sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryStoreWithFileLog.java PRE-CREATION 

Diff: https://reviews.apache.org/r/29042/diff/


Testing
-------


Thanks,

Arun Suresh


Re: Review Request 29042: SENTRY-567: SentryStore Decorator that adds Persistence to a given base SentryStore

Posted by Arun Suresh <ar...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29042/
-----------------------------------------------------------

(Updated Dec. 15, 2014, 9:45 a.m.)


Review request for sentry, bc Wong, Lenni Kuff, Prasad Mujumdar, and Sravya Tirukkovalur.


Changes
-------

improved description


Repository: sentry


Description (updated)
-------

This patch includes a base SentryStore Decorator (PersistentSentryStore) that can be used to log write operations on a SentryStore. This can be coupled with the InMemSentryStore to support Service restarts.
It patch also inclues an implementations (and associated testcases) for this Decorator
 1) SentryStoreWithFileLog logs all operations to a configured log directory. This is currently implemented as a write-behind log. it writes the entry to the log if the record has been successfully accepted by the backing SentryStore.

To ensure that the log file does not grow indefinitely, It is periodically compacted by writing out a SentryStore snapshot.

More decription on the JIRA : issues.apache.org/jira/browse/SENTRY-567


Diffs
-----

  sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/FileLog.java PRE-CREATION 
  sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/PersistentSentryStore.java PRE-CREATION 
  sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStoreWithFileLog.java PRE-CREATION 
  sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/persistent/TestFileLog.java PRE-CREATION 
  sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryStoreWithFileLog.java PRE-CREATION 

Diff: https://reviews.apache.org/r/29042/diff/


Testing
-------


Thanks,

Arun Suresh