You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@openwhisk.apache.org by GitBox <gi...@apache.org> on 2020/05/04 15:22:44 UTC

[GitHub] [openwhisk] mcdan commented on a change in pull request #4855: Improvements to parameter encryption to support per-namespace keys

mcdan commented on a change in pull request #4855:
URL: https://github.com/apache/openwhisk/pull/4855#discussion_r419516512



##########
File path: common/scala/src/main/scala/org/apache/openwhisk/core/entity/Parameter.scala
##########
@@ -252,29 +268,6 @@ protected[core] object Parameters extends ArgNormalizer[Parameters] {
     ParameterValue(Option(v).getOrElse(JsNull), false, None))
   }
 
-  def readMergedList(value: JsValue): Parameters =

Review comment:
       Yea that's a simpler way of looking at it but that changed the wire protocol for kafka right?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org