You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@bookkeeper.apache.org by GitBox <gi...@apache.org> on 2022/03/15 22:48:17 UTC

[GitHub] [bookkeeper] mauricebarnum commented on pull request #2686: Rocksdb tombstones

mauricebarnum commented on pull request #2686:
URL: https://github.com/apache/bookkeeper/pull/2686#issuecomment-1068539002


   The motivation to call `compactRange` was to quickly drop all of the rocksdb entries in a range when deleting a bunch of ledgers in GC so that seeking wouldn't run into all of the tombstones: the keys will be grouped together and much of the work should simply be deleting SSTs in the range.   A smarter approach for "delete a bunch of ledgers" to cause RocksDB to schedule a background compaction "soon".  When I made this change, stalling GC shouldn't didn't seem to be too bad.  Forcing synchronous compaction during checkpointing was a mistake.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org