You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2023/01/04 14:51:38 UTC
[GitHub] [kafka] edoardocomar opened a new pull request, #13073: KAFKA-14571: MINOR fix to include rack info in ZkMetadataCache.getClusterMetadata
edoardocomar opened a new pull request, #13073:
URL: https://github.com/apache/kafka/pull/13073
`ZkMetadataCache.getClusterMetadata` returns a Cluster object where the aliveNodes were missing their rack info.
problem: when ZkMetadataCache updates the metadataSnapshot, includes the rack in `aliveBrokers` but not in `aliveNodes`
trivial fix with matching assertion in existing unit test.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] edoardocomar commented on pull request #13073: KAFKA-14571: MINOR fix to include rack info in ZkMetadataCache.getClusterMetadata
Posted by GitBox <gi...@apache.org>.
edoardocomar commented on PR #13073:
URL: https://github.com/apache/kafka/pull/13073#issuecomment-1371027547
commit can be cherry picked cleanly in 3.3
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] ijuma commented on pull request #13073: KAFKA-14571: Include rack info in ZkMetadataCache.getClusterMetadata
Posted by GitBox <gi...@apache.org>.
ijuma commented on PR #13073:
URL: https://github.com/apache/kafka/pull/13073#issuecomment-1371550279
Merged to trunk, 3.4 and 3.3.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] ijuma commented on pull request #13073: KAFKA-14571: Include rack info in ZkMetadataCache.getClusterMetadata
Posted by GitBox <gi...@apache.org>.
ijuma commented on PR #13073:
URL: https://github.com/apache/kafka/pull/13073#issuecomment-1371494418
I see, makes sense. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] edoardocomar commented on pull request #13073: KAFKA-14571: Include rack info in ZkMetadataCache.getClusterMetadata
Posted by GitBox <gi...@apache.org>.
edoardocomar commented on PR #13073:
URL: https://github.com/apache/kafka/pull/13073#issuecomment-1371208107
> Thanks for the PR. Does this mean we are returning incorrect information to clients?
Hi @ijuma
thankfully we're not returning incorrect info in the describeCluster API
I actually found about the bug because of a discrepancy between the response of an admin client and an internal check we were doing on the metadatacache. That's why I flagged it as minor
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] edoardocomar commented on pull request #13073: KAFKA-14571: Include rack info in ZkMetadataCache.getClusterMetadata
Posted by GitBox <gi...@apache.org>.
edoardocomar commented on PR #13073:
URL: https://github.com/apache/kafka/pull/13073#issuecomment-1371482567
@ijuma
the `Cluster` object returned from `MetadataCache.getClusterMetadata(...)`
is passed to `ClientQuotaCallback.updateClusterMetadata(...)`
so I'd say it is used, though not by clients, but by service providers
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] ijuma commented on pull request #13073: KAFKA-14571: MINOR fix to include rack info in ZkMetadataCache.getClusterMetadata
Posted by GitBox <gi...@apache.org>.
ijuma commented on PR #13073:
URL: https://github.com/apache/kafka/pull/13073#issuecomment-1371169685
Thanks for the PR. Does this mean we are returning incorrect information to clients?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] ijuma commented on pull request #13073: KAFKA-14571: Include rack info in ZkMetadataCache.getClusterMetadata
Posted by GitBox <gi...@apache.org>.
ijuma commented on PR #13073:
URL: https://github.com/apache/kafka/pull/13073#issuecomment-1371218226
@edoardocomar Got it. If this is not exposed internally, then we can adjust it back to minor.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] ijuma merged pull request #13073: KAFKA-14571: Include rack info in ZkMetadataCache.getClusterMetadata
Posted by GitBox <gi...@apache.org>.
ijuma merged PR #13073:
URL: https://github.com/apache/kafka/pull/13073
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org