[GitHub] [rocketmq] RongtongJin opened a new issue #1464: Master node route info was lost when some node restarted and joined the group in dledger mode

[GitBox <gi...@apache.org>]

RongtongJin opened a new issue #1464: Master node route info was lost when some node restarted and joined the group in dledger mode
URL: https://github.com/apache/rocketmq/issues/1464
 
 
   **BUG REPORT**
   
   1. Please describe the issue you observed:
   
   - What did you do (The steps to reproduce)?
   
   when I running rocketmq on dledger with jepsen test, I found master node route info was lost when a node restarted and joined the group. It caused the service to be unavailable for a period of time until master re-registered with nameserver.
   
   - What did you expect to see?
   
   When node restart and join the group, the service is still available.
   
   2. Please tell us about your environment:
   
   centos 7
   
   3. Other information (e.g. detailed explanation, logs, related issues, suggestions how to fix, etc):
   
   Since brokerId defaults to 0,
   
   https://github.com/apache/rocketmq/blob/247e0bfbe4f17cd757a595f580f1801bb1934468/common/src/main/java/org/apache/rocketmq/common/BrokerConfig.java#L42
   
   when broker restart, it will register with namserver before brokerId is changed(when dledger role is changed), 
   
   https://github.com/apache/rocketmq/blob/247e0bfbe4f17cd757a595f580f1801bb1934468/broker/src/main/java/org/apache/rocketmq/broker/BrokerController.java#L864
   
   causing the route info of master to be overwritten.
   
   
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services