[jira] [Commented] (SOLR-10247) Support non-numeric metrics

["Shalin Shekhar Mangar (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SOLR-10247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15903144#comment-15903144 ] 

Shalin Shekhar Mangar commented on SOLR-10247:
----------------------------------------------

# The patch removes the following gauges from UpdateLog: replayLogsCountGauge, replayBytesGauge, stateGauge -- I think this is a mistake?
# nit - DirectUpdateHandlerTest has an unused import which will cause precommit to fail
# In IndexWriter's constructor, while registering the gauge {{() -> runningMajorMerges}}  -- shouldn't that be {{() -> runningMajorMerges.get()}}? and so on for all others
# I like the compact output -- we can add a version parameter to the MetricsHandler, say version=2, that outputs the compact format -- this can become the default in 7.0

> Support non-numeric metrics
> ---------------------------
>
>                 Key: SOLR-10247
>                 URL: https://issues.apache.org/jira/browse/SOLR-10247
>             Project: Solr
>          Issue Type: Improvement
>      Security Level: Public(Default Security Level. Issues are Public) 
>          Components: metrics
>            Reporter: Andrzej Bialecki 
>            Assignee: Andrzej Bialecki 
>             Fix For: 6.5, master (7.0)
>
>         Attachments: compactFormat.png, currentFormat.png, SOLR-10247.patch
>
>
> Metrics API currently supports only numeric values. However, it's useful also to report non-numeric values such as eg. version, disk type, component state, some system properties, etc.
> Codahale {{Gauge<T>}} metric type can be used for this purpose, and convenience methods can be added to {{SolrMetricManager}} to make it easier to use.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org