You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Vinod Kone <vi...@gmail.com> on 2013/08/12 19:49:44 UTC
Re: Review Request 13486: Fixed executor driver to store tasks and updates
in LinkedHashMap.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13486/
-----------------------------------------------------------
(Updated Aug. 12, 2013, 5:49 p.m.)
Review request for mesos, Benjamin Hindman and Ben Mahler.
Changes
-------
s/linkedhashmap/LinkedHashMap/
Summary (updated)
-----------------
Fixed executor driver to store tasks and updates in LinkedHashMap.
Bugs: MESOS-637
https://issues.apache.org/jira/browse/MESOS-637
Repository: mesos-git
Description
-------
This ensures that executor driver reregisters with tasks and updates in the same order as they were received.
Diffs (updated)
-----
src/exec/exec.cpp d46772464221f425715810983295ac7dacb66ccc
Diff: https://reviews.apache.org/r/13486/diff/
Testing
-------
make check
Thanks,
Vinod Kone
Re: Review Request 13486: Fixed executor driver to store tasks and updates
in LinkedHashMap.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13486/
-----------------------------------------------------------
(Updated Aug. 14, 2013, 6:04 p.m.)
Review request for mesos, Benjamin Hindman and Ben Mahler.
Changes
-------
benm's. nnfr.
Bugs: MESOS-637
https://issues.apache.org/jira/browse/MESOS-637
Repository: mesos-git
Description
-------
This ensures that executor driver reregisters with tasks and updates in the same order as they were received.
Diffs (updated)
-----
src/exec/exec.cpp d46772464221f425715810983295ac7dacb66ccc
Diff: https://reviews.apache.org/r/13486/diff/
Testing
-------
make check
Thanks,
Vinod Kone
Re: Review Request 13486: Fixed executor driver to store tasks and updates
in LinkedHashMap.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13486/#review25104
-----------------------------------------------------------
Ship it!
Can you add TODOs on each of the .values() calls to use foreachvalue when LinkeHashMap supports it? I want to make sure we keep track of these unnecessary copies and revert them once we can.
- Ben Mahler
On Aug. 12, 2013, 5:49 p.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13486/
> -----------------------------------------------------------
>
> (Updated Aug. 12, 2013, 5:49 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Ben Mahler.
>
>
> Bugs: MESOS-637
> https://issues.apache.org/jira/browse/MESOS-637
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> This ensures that executor driver reregisters with tasks and updates in the same order as they were received.
>
>
> Diffs
> -----
>
> src/exec/exec.cpp d46772464221f425715810983295ac7dacb66ccc
>
> Diff: https://reviews.apache.org/r/13486/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Vinod Kone
>
>