You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/04/20 09:07:28 UTC
[GitHub] [spark] wangyum opened a new pull request #24423:
[SPARK-27525][SQL] Exclude commons-httpclient when interacting with
different versions of the HiveMetastoreClient
wangyum opened a new pull request #24423: [SPARK-27525][SQL] Exclude commons-httpclient when interacting with different versions of the HiveMetastoreClient
URL: https://github.com/apache/spark/pull/24423
## What changes were proposed in this pull request?
Our jenkins sometimes failed download `commons-httpclient#commons-httpclient;3.0.1`:
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/104768/testReport/org.apache.spark.sql.hive.execution/Hive_2_1_DDLSuite/SPARK_21617__ALTER_TABLE_for_non_compatible_DataSource_tables
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/104768/testReport/org.apache.spark.sql.hive/HiveExternalCatalogVersionsSuite/backward_compatibility
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/104750/testReport/org.apache.spark.sql.hive.execution/Hive_2_1_DDLSuite/SPARK_21617__ALTER_TABLE_for_non_compatible_DataSource_tables
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/104750/testReport/org.apache.spark.sql.hive/HiveExternalCatalogVersionsSuite/backward_compatibility
So this pr exclude it when interacting with different versions of the HiveMetastoreClient.
The commons-httpclient only used in [LoadSemanticAnalyzer.java#L30](https://github.com/apache/hive/blob/release-2.0.1/ql/src/java/org/apache/hadoop/hive/ql/parse/LoadSemanticAnalyzer.java#L30). Therefore, the Hive's load command will not work after this PR.
## How was this patch tested?
1. jenkins tests interacting with different versions of the HiveMetastoreClient still works fine.
2. manual tests it only affects `runSqlHive`, adding the following test to `Hive_2_1_DDLSuite`:
```scala
test("SPARK-27525") {
catalog.client.runSqlHive("create table spark_27525(key int, value string)")
catalog.client.runSqlHive(
"load data local inpath './src/test/resources/data/files/things.txt' into table spark_27525")
}
//Exception:
[info] org.apache.spark.sql.hive.execution.Hive_2_1_DDLSuite *** ABORTED *** (25 seconds, 845 milliseconds)
[info] java.lang.NoClassDefFoundError: org/apache/commons/httpclient/util/URIUtil
[info] at org.apache.hadoop.hive.ql.parse.LoadSemanticAnalyzer.initializeFromURI(LoadSemanticAnalyzer.java:101)
[info] at org.apache.hadoop.hive.ql.parse.LoadSemanticAnalyzer.analyzeInternal(LoadSemanticAnalyzer.java:190)
[info] at org.apache.hadoop.hive.ql.parse.BaseSemanticAnalyzer.analyze(BaseSemanticAnalyzer.java:250)
[info] at org.apache.hadoop.hive.ql.Driver.compile(Driver.java:477)
[info] at org.apache.hadoop.hive.ql.Driver.compileInternal(Driver.java:1242)
[info] at org.apache.hadoop.hive.ql.Driver.runInternal(Driver.java:1384)
[info] at org.apache.hadoop.hive.ql.Driver.run(Driver.java:1171)
[info] at org.apache.hadoop.hive.ql.Driver.run(Driver.java:1161)
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org