You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by astroshim <gi...@git.apache.org> on 2016/12/29 05:21:56 UTC
[GitHub] zeppelin pull request #1813: [ZEPPELIN-1868]fix to not shows up the login bu...
GitHub user astroshim opened a pull request:
https://github.com/apache/zeppelin/pull/1813
[ZEPPELIN-1868]fix to not shows up the login button on Anonymous mode.
### What is this PR for?
This PR fixs to not shows up the login button on Anonymous mode.
### What type of PR is it?
Bug Fix
### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-1868
### How should this be tested?
1. Give permission on note.
2. Turn off the shiro.
3. Delete note that you made on 1.
4. Then you can see the `login button` like as screen shot.
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/astroshim/zeppelin feat/skipLogin
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1813.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1813
----
commit ba7218872f75a8341ae2dd24d32b6544c40f35c1
Author: astroshim <hs...@zepl.com>
Date: 2016-12-29T05:12:43Z
fix to not shows up the login button on Anonymous mode.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1813: [ZEPPELIN-1868]fix to not shows up the login button on...
Posted by soralee <gi...@git.apache.org>.
Github user soralee commented on the issue:
https://github.com/apache/zeppelin/pull/1813
Tested and It works as expected like below!!
[Before]
[After]
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1813: [ZEPPELIN-1868]fix to not shows up the login button on...
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/1813
LGTM. Merge if there are no more comments
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1813: [ZEPPELIN-1868]fix to not shows up the login button on...
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/1813
Yeah it makes sense. Tested and it's working well \U0001f44d
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1813: [ZEPPELIN-1868]fix to not shows up the login bu...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/1813
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1813: [ZEPPELIN-1868]fix to not shows up the login button on...
Posted by astroshim <gi...@git.apache.org>.
Github user astroshim commented on the issue:
https://github.com/apache/zeppelin/pull/1813
@soralee Thank you for reviewing and commenting!!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1813: [ZEPPELIN-1868]fix to not shows up the login button on...
Posted by soralee <gi...@git.apache.org>.
Github user soralee commented on the issue:
https://github.com/apache/zeppelin/pull/1813
@astroshim It's great work! I will test it!
But, I would like to suggest one thing. According to what I understand, your screenshot and `Then you can see the login button like as screen shot.` is the content before fixing bug in this PR description, right?
I think in this part, It makes confusing for your description of PR.
So, it would be clear if there is content after fixing the bug.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---