You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/07/30 22:00:50 UTC

[GitHub] [superset] serenajiang opened a new pull request #15992: fix(sqllab): revert #15891 to fix sqllab delay

serenajiang opened a new pull request #15992:
URL: https://github.com/apache/superset/pull/15992


   This reverts commit 8c7e09e500129aaa4f52cfaabe81e4d4a6970cde.
   
   ### SUMMARY
   #15891 caused some delays with the sql state in SQL Lab, resulting in the incorrect query being run if a user edited and ran a query quickly. Reverting this PR for now.
   
   ### TESTING INSTRUCTIONS
   N/A, but how I tested the bug:
   1. Go to sql lab
   2. Type "SELECT 1"
   3. Wait ~10 seconds
   4. Quickly modify the query to be "SELECT 2" and click "Run"
   5. Observe which query was run (1 or 2)
   
   I confirmed that before this change, the incorrect query was run (SELECT 1), and after this change, the correct query was run (SELECT 2).
   
   to: @graceguo-supercat 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] serenajiang merged pull request #15992: fix(sqllab): revert #15891 to fix sqllab delay

Posted by GitBox <gi...@apache.org>.
serenajiang merged pull request #15992:
URL: https://github.com/apache/superset/pull/15992


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org