[GitHub] [pulsar] poorbarcode commented on pull request #15413: [Java Client] Fix wrong behavior of deduplication for key based batching

[GitBox <gi...@apache.org>]

poorbarcode commented on PR #15413:
URL: https://github.com/apache/pulsar/pull/15413#issuecomment-1115264049

   Hi @BewareMyPower. I don't think we've solved the problem. 
   
   - The original implementation, you think there might be this duplication: 
   
   ```
   // batch 1th
   send [seq_1, seq_3]
   // batch 2th
   send [seq_2, seq_3]
   ```
   So the message which is sequence_3 was repeated. 
   
   - After this piece of code changes, is there such a repeated message ?
   ```
   // batch 1th
   send [seq_1, seq_5]
   // batch 2th
   send [seq_1, seq_3]
   ```
   
   So the message which is sequence_1 was repeated.  
   
   
   I don't know whether I have correctly understood your meaning. If there is any misunderstanding, thank you for telling me.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org