[GitHub] [spark] wangshengjie123 commented on a diff in pull request #37528: [SPARK-40094][CORE] Send TaskEnd event when task failed with NotSerializableException or TaskOutputFileAlreadyExistException

[GitBox <gi...@apache.org>]

wangshengjie123 commented on code in PR #37528:
URL: https://github.com/apache/spark/pull/37528#discussion_r952062899


##########
core/src/test/scala/org/apache/spark/scheduler/TaskSetManagerSuite.scala:
##########
@@ -2596,28 +2605,39 @@ class TaskSetManagerSuite
       .getDeclaredMethod("ensureExecutorIsTracked",
         classOf[String], classOf[Int])
     ensureExecutorIsTracked.setAccessible(true)
-    val executorTracker = ensureExecutorIsTracked.invoke(executorMonitor,
+
+    val executorTracker1 = ensureExecutorIsTracked.invoke(executorMonitor,
       "exec1".asInstanceOf[AnyRef],
       ResourceProfile.DEFAULT_RESOURCE_PROFILE_ID.asInstanceOf[AnyRef])
-    executorTracker.asInstanceOf[executorMonitor.Tracker].updateRunningTasks(1)
+    executorTracker1.asInstanceOf[executorMonitor.Tracker].updateRunningTasks(1)
+    val executorTracker2 = ensureExecutorIsTracked.invoke(executorMonitor,
+      "exec2".asInstanceOf[AnyRef],
+      ResourceProfile.DEFAULT_RESOURCE_PROFILE_ID.asInstanceOf[AnyRef])
+    executorTracker2.asInstanceOf[executorMonitor.Tracker].updateRunningTasks(1)
 
-    // assert exec1 is not idle
+    // assert exec1 and exec2 is not idle

Review Comment:
   Got that. Fixed later, thanks



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org