You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "blaginin (via GitHub)" <gi...@apache.org> on 2026/04/29 22:18:56 UTC

[PR] Rust checks are required + MQ [datafusion]

blaginin opened a new pull request, #21941:
URL: https://github.com/apache/datafusion/pull/21941

   Closes https://github.com/apache/datafusion/issues/6880
   Follow up on https://github.com/apache/datafusion/pull/17538 and https://github.com/apache/datafusion/pull/21239
   
   https://github.com/apache/datafusion/pull/21239 seems to be working fine - time to make all the rust changes required to merge it.
   
   This brings two cool things:
   
   1. The most important one - the "merge when ready" button now works 🚀
   <img width="923" height="285" alt="image" src="https://github.com/user-attachments/assets/4f11ecb6-e1d9-473f-815f-b57488042dd3" />
   
   You can click this button any time, even right after opening a PR. It will be automatically merged when:
   - all required CI checks (which now include rust) are passing
   - you get an approval
   
   I think this should help quite a bit. A lot of people get an approval, push a nit, and then sit waiting for CI to finish. No more waiting!!
   
   2. We protect ourselves from logical conflicts: cases where develop was passing before, but someone merged something in the meantime and now your change is broken on develop - and you don't find out until after you merge. We hit this almost every month.
   
   One downside: before, clicking merge would happen instantly. Now you'll have to wait 20 minutes. But you don't actually have to wait - github will do the work itself.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org


Re: [PR] chore: Rust checks are required + merge queue [datafusion]

Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #21941:
URL: https://github.com/apache/datafusion/pull/21941#issuecomment-4390097638

   woogoo!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org


Re: [PR] chore: Rust checks are required + merge queue [datafusion]

Posted by "comphead (via GitHub)" <gi...@apache.org>.
comphead commented on PR #21941:
URL: https://github.com/apache/datafusion/pull/21941#issuecomment-4362932432

   thanks @blaginin 
   another micro optimization prob is to check 0 tests
   
   ```
   running 0 tests
   
   test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s
   ```
   
   the execution takes nothing but planning might take something, 14 entries for linux tests and 20 for macos


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org


Re: [PR] chore: Rust checks are required + merge queue [datafusion]

Posted by "blaginin (via GitHub)" <gi...@apache.org>.
blaginin commented on PR #21941:
URL: https://github.com/apache/datafusion/pull/21941#issuecomment-4390165227

   <img width="879" height="250" alt="image" src="https://github.com/user-attachments/assets/a181907d-99ad-4343-a239-1ba26d6db128" />
   
   noticed that, will clean up now


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org


Re: [PR] chore: Rust checks are required + merge queue [datafusion]

Posted by "blaginin (via GitHub)" <gi...@apache.org>.
blaginin commented on PR #21941:
URL: https://github.com/apache/datafusion/pull/21941#issuecomment-4389028215

   thanks! @comphead 
   
   > another micro optimization prob
   yeah for sure, let's merge this and then i'll optimize that on top? 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org


Re: [PR] chore: Rust checks are required + merge queue [datafusion]

Posted by "blaginin (via GitHub)" <gi...@apache.org>.
blaginin commented on PR #21941:
URL: https://github.com/apache/datafusion/pull/21941#issuecomment-4390334412

   actually, it's actually expected - since the required checks became required AFTER we merged this PR, so the new ones should be working correctly!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org


Re: [PR] Rust checks are required + MQ [datafusion]

Posted by "blaginin (via GitHub)" <gi...@apache.org>.
blaginin commented on PR #21941:
URL: https://github.com/apache/datafusion/pull/21941#issuecomment-4348024928

   Now it will take 2x16 minutes to perform a merge (16 mins to put the PR in the queue + 16 mins to merge in the queue). I think that's OK since it's all automated. But we can actually make it MUCH faster - 2x6 mins instead.
   
   <img width="564" height="658" alt="image" src="https://github.com/user-attachments/assets/5059c18d-cbd5-44c2-8b8f-eacc650f22fd" />
   
   You can see that the actual bottleneck is the Mac OS tests - that's because runs-on doesn't support them. My ideas:
   - kill the Mac OS tests. Although every three months or so there's 1-2 PRs that fail JUST on them, so probably not a good idea.
   - introduce an "Optional Mac OS Check": this won't run on push to a PR, but will run when the PR is in the merge queue. So instead of 2x16 mins it'll be just 1x16 mins (only in the merge queue). We can do the same with extended tests, which currently aren't required and only run on develop in full.
   - work with the infra team to get access to more performant github runners. Can take a while but i'm happy to do that!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org


Re: [PR] chore: Rust checks are required + merge queue [datafusion]

Posted by "comphead (via GitHub)" <gi...@apache.org>.
comphead merged PR #21941:
URL: https://github.com/apache/datafusion/pull/21941


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org


Re: [PR] Rust checks are required + MQ [datafusion]

Posted by "blaginin (via GitHub)" <gi...@apache.org>.
blaginin commented on code in PR #21941:
URL: https://github.com/apache/datafusion/pull/21941#discussion_r3164534785


##########
.github/workflows/rust.yml:
##########
@@ -33,14 +33,11 @@ on:
       - ".github/ISSUE_TEMPLATE/**"
       - ".github/pull_request_template.md"
   pull_request:
-    paths-ignore:
-      - "docs/**"
-      - "**.md"
-      - ".github/ISSUE_TEMPLATE/**"
-      - ".github/pull_request_template.md"

Review Comment:
   a bit annoying that we'll run those on every pr even on those that changes docs. but: 
   - we don't have many of those anyway
   - i really [tried](https://github.com/apache/datafusion-sandbox/pulls?q=is%3Apr+author%3Ablaginin+is%3Aclosed) to fix this, but it makes the CI very complicated to install and support in the future



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org