You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@helix.apache.org by GitBox <gi...@apache.org> on 2022/03/30 03:55:52 UTC
[GitHub] [helix] desaikomal opened a new pull request #1998: [WIP] Re-Introduce Helix View Aggregator
desaikomal opened a new pull request #1998:
URL: https://github.com/apache/helix/pull/1998
This is WIP and this change only ensures compilation of helix-view-aggregator
### Issues
- [ ] My PR addresses the following Helix issues and references them in the PR description:
Any of the following keywords can be used: close, closes, closed, fix, fixes, fixed, resolve, resolves, resolved)
### Description
- [ ] Here are some details about my PR, including screenshots of any UI changes:
(Write a concise description including what, why, how)
### Tests
- [ ] The following tests are written for this issue:
(List the names of added unit/integration tests)
- The following is the result of the "mvn test" command on the appropriate module:
(If CI test fails due to known issue, please specify the issue and test PR locally. Then copy & paste the result of "mvn test" to here.)
### Changes that Break Backward Compatibility (Optional)
- My PR contains changes that break backward compatibility or previous assumptions for certain methods or API. They include:
(Consider including all behavior changes for public methods or API. Also include these changes in merge description so that other developers are aware of these changes. This allows them to make relevant code changes in feature branches accounting for the new method/API behavior.)
### Documentation (Optional)
- In case of new functionality, my PR adds documentation in the following wiki page:
(Link the GitHub wiki you added)
### Commits
- My commits all reference appropriate Apache Helix GitHub issues in their subject lines. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Code Quality
- My diff has been formatted using helix-style.xml
(helix-style-intellij.xml if IntelliJ IDE is used)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] desaikomal commented on a change in pull request #1998: [WIP] Re-Introduce Helix View Aggregator
Posted by GitBox <gi...@apache.org>.
desaikomal commented on a change in pull request #1998:
URL: https://github.com/apache/helix/pull/1998#discussion_r839004999
##########
File path: helix-view-aggregator/error
##########
@@ -0,0 +1,103 @@
+[INFO] Scanning for projects...
Review comment:
this was due to addition of the whole directory. I will clean up.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] desaikomal commented on a change in pull request #1998: [WIP] Re-Introduce Helix View Aggregator
Posted by GitBox <gi...@apache.org>.
desaikomal commented on a change in pull request #1998:
URL: https://github.com/apache/helix/pull/1998#discussion_r839005573
##########
File path: helix-view-aggregator/pom.xml
##########
@@ -0,0 +1,141 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!--
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements. See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership. The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied. See the License for the
+specific language governing permissions and limitations
+under the License.
+-->
+<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
+ <parent>
+ <groupId>org.apache.helix</groupId>
+ <artifactId>helix</artifactId>
+ <version>1.0.3-SNAPSHOT</version>
+ </parent>
+ <modelVersion>4.0.0</modelVersion>
+
+ <artifactId>helix-view-aggregator</artifactId>
+ <packaging>bundle</packaging>
+ <name>Apache Helix :: View Aggregator</name>
+
+ <properties>
+ <osgi.import>
+ org.apache.helix*,
+ org.codehaus.jackson*,
+ org.apache.commons.cli*,
+ org.slf4j*;version="[1.7,2)",
+ *
+ </osgi.import>
+ <osgi.export>org.apache.helix.view*;version="${project.version};-noimport:=true</osgi.export>
+ </properties>
+
+ <dependencies>
+ <dependency>
+ <groupId>io.dropwizard.metrics</groupId>
+ <artifactId>metrics-core</artifactId>
+ <version>3.2.3</version>
+ </dependency>
+ <dependency>
+ <groupId>org.slf4j</groupId>
Review comment:
this is what helix-controller is using.. will change later for all of our components.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] desaikomal commented on a change in pull request #1998: [WIP] Re-Introduce Helix View Aggregator
Posted by GitBox <gi...@apache.org>.
desaikomal commented on a change in pull request #1998:
URL: https://github.com/apache/helix/pull/1998#discussion_r839004794
##########
File path: helix-core/src/main/java/org/apache/helix/model/ClusterConfig.java
##########
@@ -82,6 +84,10 @@
// error exceeds this limitation
DISABLED_INSTANCES,
+ VIEW_CLUSTER, // Set to "true" to indicate this is a view cluster
+ VIEW_CLUSTER_SOURCES, // Map field, key is the name of source cluster, value is
+ // ViewClusterSourceConfig JSON string
+ VIEW_CLUSTER_REFRESH_PERIOD, // In second
Review comment:
This was lift-n-shift from old existing code. Can I defer this improvement for next change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] narendly commented on a change in pull request #1998: [WIP] Re-Introduce Helix View Aggregator
Posted by GitBox <gi...@apache.org>.
narendly commented on a change in pull request #1998:
URL: https://github.com/apache/helix/pull/1998#discussion_r838720319
##########
File path: helix-view-aggregator/pom.xml
##########
@@ -0,0 +1,141 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!--
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements. See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership. The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied. See the License for the
+specific language governing permissions and limitations
+under the License.
+-->
+<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
+ <parent>
+ <groupId>org.apache.helix</groupId>
+ <artifactId>helix</artifactId>
+ <version>1.0.3-SNAPSHOT</version>
+ </parent>
+ <modelVersion>4.0.0</modelVersion>
+
+ <artifactId>helix-view-aggregator</artifactId>
+ <packaging>bundle</packaging>
+ <name>Apache Helix :: View Aggregator</name>
+
+ <properties>
+ <osgi.import>
+ org.apache.helix*,
+ org.codehaus.jackson*,
+ org.apache.commons.cli*,
+ org.slf4j*;version="[1.7,2)",
+ *
+ </osgi.import>
+ <osgi.export>org.apache.helix.view*;version="${project.version};-noimport:=true</osgi.export>
+ </properties>
+
+ <dependencies>
+ <dependency>
+ <groupId>io.dropwizard.metrics</groupId>
+ <artifactId>metrics-core</artifactId>
+ <version>3.2.3</version>
+ </dependency>
+ <dependency>
+ <groupId>org.slf4j</groupId>
Review comment:
Is this logger version new? Let's make sure we don't use versions that are known to have vulnerabilities.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] desaikomal commented on a change in pull request #1998: [WIP] Re-Introduce Helix View Aggregator
Posted by GitBox <gi...@apache.org>.
desaikomal commented on a change in pull request #1998:
URL: https://github.com/apache/helix/pull/1998#discussion_r839005271
##########
File path: helix-view-aggregator/pom.xml
##########
@@ -0,0 +1,141 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!--
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements. See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership. The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied. See the License for the
+specific language governing permissions and limitations
+under the License.
+-->
+<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
+ <parent>
+ <groupId>org.apache.helix</groupId>
+ <artifactId>helix</artifactId>
+ <version>1.0.3-SNAPSHOT</version>
+ </parent>
+ <modelVersion>4.0.0</modelVersion>
+
+ <artifactId>helix-view-aggregator</artifactId>
+ <packaging>bundle</packaging>
+ <name>Apache Helix :: View Aggregator</name>
+
+ <properties>
+ <osgi.import>
+ org.apache.helix*,
+ org.codehaus.jackson*,
Review comment:
i will make the change as i had to fix jackson dependencies in class to use fasterxml already.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] junkaixue commented on pull request #1998: [WIP] Re-Introduce Helix View Aggregator
Posted by GitBox <gi...@apache.org>.
junkaixue commented on pull request #1998:
URL: https://github.com/apache/helix/pull/1998#issuecomment-1084901150
It seemed to be pure copy of the code? Is this possible we have historical commits ported from the branch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] narendly commented on a change in pull request #1998: [WIP] Re-Introduce Helix View Aggregator
Posted by GitBox <gi...@apache.org>.
narendly commented on a change in pull request #1998:
URL: https://github.com/apache/helix/pull/1998#discussion_r838715869
##########
File path: helix-core/src/main/java/org/apache/helix/model/ClusterConfig.java
##########
@@ -82,6 +84,10 @@
// error exceeds this limitation
DISABLED_INSTANCES,
+ VIEW_CLUSTER, // Set to "true" to indicate this is a view cluster
+ VIEW_CLUSTER_SOURCES, // Map field, key is the name of source cluster, value is
+ // ViewClusterSourceConfig JSON string
+ VIEW_CLUSTER_REFRESH_PERIOD, // In second
Review comment:
Nit: I find that it's much clearer to just encode the unit in the enum. Should we just do `VIEW_CLUSTER_REFRESH_PERIOD_IN_SEC`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] narendly commented on a change in pull request #1998: [WIP] Re-Introduce Helix View Aggregator
Posted by GitBox <gi...@apache.org>.
narendly commented on a change in pull request #1998:
URL: https://github.com/apache/helix/pull/1998#discussion_r838717095
##########
File path: helix-view-aggregator/error
##########
@@ -0,0 +1,103 @@
+[INFO] Scanning for projects...
Review comment:
Did you mean to include this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] narendly commented on a change in pull request #1998: [WIP] Re-Introduce Helix View Aggregator
Posted by GitBox <gi...@apache.org>.
narendly commented on a change in pull request #1998:
URL: https://github.com/apache/helix/pull/1998#discussion_r838718977
##########
File path: helix-view-aggregator/pom.xml
##########
@@ -0,0 +1,141 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!--
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements. See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership. The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied. See the License for the
+specific language governing permissions and limitations
+under the License.
+-->
+<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
+ <parent>
+ <groupId>org.apache.helix</groupId>
+ <artifactId>helix</artifactId>
+ <version>1.0.3-SNAPSHOT</version>
+ </parent>
+ <modelVersion>4.0.0</modelVersion>
+
+ <artifactId>helix-view-aggregator</artifactId>
+ <packaging>bundle</packaging>
+ <name>Apache Helix :: View Aggregator</name>
+
+ <properties>
+ <osgi.import>
+ org.apache.helix*,
+ org.codehaus.jackson*,
Review comment:
Helix has since gotten rid of codehaus jackson. Could we use fasterxml so that we are being consistent with other modules?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] desaikomal commented on pull request #1998: [WIP] Re-Introduce Helix View Aggregator
Posted by GitBox <gi...@apache.org>.
desaikomal commented on pull request #1998:
URL: https://github.com/apache/helix/pull/1998#issuecomment-1084908864
> I don't know how to get commit history for view-aggregator. Let me do some more research on how to get that and update the PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] narendly commented on pull request #1998: [WIP] Re-Introduce Helix View Aggregator
Posted by GitBox <gi...@apache.org>.
narendly commented on pull request #1998:
URL: https://github.com/apache/helix/pull/1998#issuecomment-1085187981
> > I don't know how to get commit history for view-aggregator. Let me do some more research on how to get that and update the PR
If you do a format-patch, then you can preserve the commit history.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org