You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by PascalSchumacher <gi...@git.apache.org> on 2015/05/05 23:32:49 UTC
[GitHub] commons-lang pull request: remove compiler warnings from ThreadUti...
GitHub user PascalSchumacher opened a pull request:
https://github.com/apache/commons-lang/pull/83
remove compiler warnings from ThreadUtils
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/PascalSchumacher/commons-lang remove_ThreadUtils_compiler_warnings
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/commons-lang/pull/83.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #83
----
commit 7d5a61ed64315bd6570c5cb55c1f53853a3fffa5
Author: Pascal Schumacher <pa...@gmx.net>
Date: 2015-05-05T21:31:20Z
remove compiler warnings from ThreadUtils
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] commons-lang pull request: remove compiler warnings from ThreadUti...
Posted by PascalSchumacher <gi...@git.apache.org>.
Github user PascalSchumacher commented on the pull request:
https://github.com/apache/commons-lang/pull/83#issuecomment-99986258
Thanks for merging! :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] commons-lang pull request: remove compiler warnings from ThreadUti...
Posted by britter <gi...@git.apache.org>.
Github user britter commented on a diff in the pull request:
https://github.com/apache/commons-lang/pull/83#discussion_r29866464
--- Diff: src/main/java/org/apache/commons/lang3/ThreadUtils.java ---
@@ -292,12 +292,12 @@ private AlwaysTruePredicate() {
}
@Override
- public boolean test(@SuppressWarnings("unused") final ThreadGroup threadGroup) {
--- End diff --
Which IDE are you using? My IDE (IntelliJ 14.2) says this is okay.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] commons-lang pull request: remove compiler warnings from ThreadUti...
Posted by coveralls <gi...@git.apache.org>.
Github user coveralls commented on the pull request:
https://github.com/apache/commons-lang/pull/83#issuecomment-99234742
[](https://coveralls.io/builds/2494291)
Coverage decreased (-0.01%) to 93.35% when pulling **7d5a61ed64315bd6570c5cb55c1f53853a3fffa5 on PascalSchumacher:remove_ThreadUtils_compiler_warnings** into **d6dd2b4cd4a337c5517952680c3714e5d08e9cb8 on apache:master**.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] commons-lang pull request: remove compiler warnings from ThreadUti...
Posted by britter <gi...@git.apache.org>.
Github user britter commented on the pull request:
https://github.com/apache/commons-lang/pull/83#issuecomment-99962539
Thank you!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] commons-lang pull request: remove compiler warnings from ThreadUti...
Posted by PascalSchumacher <gi...@git.apache.org>.
Github user PascalSchumacher commented on a diff in the pull request:
https://github.com/apache/commons-lang/pull/83#discussion_r29869592
--- Diff: src/main/java/org/apache/commons/lang3/ThreadUtils.java ---
@@ -292,12 +292,12 @@ private AlwaysTruePredicate() {
}
@Override
- public boolean test(@SuppressWarnings("unused") final ThreadGroup threadGroup) {
--- End diff --
Eclipse 4.4.2 disagrees. ;)
Does IntelliJ require the suppression?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] commons-lang pull request: remove compiler warnings from ThreadUti...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/commons-lang/pull/83
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] commons-lang pull request: remove compiler warnings from ThreadUti...
Posted by britter <gi...@git.apache.org>.
Github user britter commented on a diff in the pull request:
https://github.com/apache/commons-lang/pull/83#discussion_r29878051
--- Diff: src/main/java/org/apache/commons/lang3/ThreadUtils.java ---
@@ -292,12 +292,12 @@ private AlwaysTruePredicate() {
}
@Override
- public boolean test(@SuppressWarnings("unused") final ThreadGroup threadGroup) {
--- End diff --
No. But if I can make Eclipse users a litte bit more happy, I'll merge this for you :-)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---