You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "Thomas Neidhart (JIRA)" <ji...@apache.org> on 2013/09/09 21:10:53 UTC
[jira] [Commented] (COLLECTIONS-481) remove composite collection
methods/constructors made redundant by vararg overloads
[ https://issues.apache.org/jira/browse/COLLECTIONS-481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13762173#comment-13762173 ]
Thomas Neidhart commented on COLLECTIONS-481:
---------------------------------------------
Hi Hollis,
the overloaded methods with two arguments are usually there to avoid the following warning with Java 1.5 / 6:
Type safety: A generic array of Set<E> is created for a varargs parameter
So we want to keep them for the time being.
In the case of the addComposited(Set[]) method: this should indeed be changed to varargs.
> remove composite collection methods/constructors made redundant by vararg overloads
> -----------------------------------------------------------------------------------
>
> Key: COLLECTIONS-481
> URL: https://issues.apache.org/jira/browse/COLLECTIONS-481
> Project: Commons Collections
> Issue Type: Improvement
> Components: Collection, List, Map, Set
> Affects Versions: 4.0-alpha1
> Reporter: Hollis Waite
> Priority: Minor
> Attachments: COLLECTIONS-481 (CompositeSet).patch
>
>
> Composite* classes overload numerous methods/constructors for the sake of convenience. However, many overloads are unnecessary as their functionality is covered by vararg implementations. Redundant code should be removed.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira