You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@kyuubi.apache.org by "Yikf (via GitHub)" <gi...@apache.org> on 2023/07/04 09:16:07 UTC
[GitHub] [kyuubi] Yikf opened a new pull request, #5017: [KSHC] Support Parquet/Orc provider is splitable
Yikf opened a new pull request, #5017:
URL: https://github.com/apache/kyuubi/pull/5017
<!--
Thanks for sending a pull request!
Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://kyuubi.readthedocs.io/en/latest/community/CONTRIBUTING.html
2. If the PR is related to an issue in https://github.com/apache/kyuubi/issues, add '[KYUUBI #XXXX]' in your PR title, e.g., '[KYUUBI #XXXX] Your PR title ...'.
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][KYUUBI #XXXX] Your PR title ...'.
-->
### _Why are the changes needed?_
<!--
Please clarify why the changes are needed. For instance,
1. If you add a feature, you can talk about the use case of it.
2. If you fix a bug, you can clarify why it is a bug.
-->
This PR amins to support Parquet/Orc provider is splitable.
### _How was this patch tested?_
- [x] Add some test cases that check the changes thoroughly including negative and positive cases if possible
- [ ] Add screenshots for manual tests if appropriate
- [x] [Run test](https://kyuubi.readthedocs.io/en/master/contributing/code/testing.html#running-tests) locally before make a pull request
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] Yikf closed pull request #5017: [KSHC] Support Parquet/Orc provider is splitable
Posted by "Yikf (via GitHub)" <gi...@apache.org>.
Yikf closed pull request #5017: [KSHC] Support Parquet/Orc provider is splitable
URL: https://github.com/apache/kyuubi/pull/5017
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] Yikf commented on a diff in pull request #5017: [KSHC] Support Parquet/Orc provider is splitable
Posted by "Yikf (via GitHub)" <gi...@apache.org>.
Yikf commented on code in PR #5017:
URL: https://github.com/apache/kyuubi/pull/5017#discussion_r1252757590
##########
extensions/spark/kyuubi-spark-connector-hive/src/main/scala/org/apache/kyuubi/spark/connector/hive/read/HiveScan.scala:
##########
@@ -54,6 +54,14 @@ case class HiveScan(
private val partFileToHivePartMap: mutable.Map[PartitionedFile, HivePartition] = mutable.Map()
+ override def isSplitable(path: Path): Boolean = {
+ catalogTable.provider.map(_.toUpperCase(Locale.ROOT)).exists {
Review Comment:
Updated
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] pan3793 commented on a diff in pull request #5017: [KSHC] Support Parquet/Orc provider is splitable
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on code in PR #5017:
URL: https://github.com/apache/kyuubi/pull/5017#discussion_r1252805084
##########
extensions/spark/kyuubi-spark-connector-hive/src/main/scala/org/apache/kyuubi/spark/connector/hive/read/HiveScan.scala:
##########
@@ -54,6 +54,15 @@ case class HiveScan(
private val partFileToHivePartMap: mutable.Map[PartitionedFile, HivePartition] = mutable.Map()
+ override def isSplitable(path: Path): Boolean = {
+ catalogTable.provider.map(_.toUpperCase(Locale.ROOT)).exists {
+ case "PARQUET" => true
+ case "ORC" => true
+ case "HIVE" if isHiveOrcOrParquet(catalogTable.storage) => true
Review Comment:
```suggestion
case "HIVE" => isHiveOrcOrParquet(catalogTable.storage)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] pan3793 commented on pull request #5017: [KSHC] Support Parquet/Orc provider is splitable
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on PR #5017:
URL: https://github.com/apache/kyuubi/pull/5017#issuecomment-1619888021
Another question not related to this PR, what's the output filename pattern written by this connector? does it has `.<codec>.<format>` suffix? e.g. `.gzip.parquet`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] pan3793 commented on pull request #5017: [KSHC] Support Parquet/Orc provider is splitable
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on PR #5017:
URL: https://github.com/apache/kyuubi/pull/5017#issuecomment-1619917473
> > Another question not related to this PR, what's the output filename pattern written by this connector? does it have `.<codec>.<format>` suffix? e.g. `.gzip.parquet`
>
> Like Spark Hive v1, it has no suffix
It's inconsistent in built-in Hive, parquet has no suffix but ORC does.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] codecov-commenter commented on pull request #5017: [KSHC] Support Parquet/Orc provider is splitable
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #5017:
URL: https://github.com/apache/kyuubi/pull/5017#issuecomment-1620177327
## [Codecov](https://app.codecov.io/gh/apache/kyuubi/pull/5017?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#5017](https://app.codecov.io/gh/apache/kyuubi/pull/5017?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (6340d3e) into [master](https://app.codecov.io/gh/apache/kyuubi/commit/1d5ac07dfceaead1c1eeb0b2b477e1ab09ccce82?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (1d5ac07) will **not change** coverage.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #5017 +/- ##
======================================
Coverage 0.00% 0.00%
======================================
Files 563 563
Lines 31167 31167
Branches 4070 4070
======================================
Misses 31167 31167
```
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] cxzl25 commented on a diff in pull request #5017: [KSHC] Support Parquet/Orc provider is splitable
Posted by "cxzl25 (via GitHub)" <gi...@apache.org>.
cxzl25 commented on code in PR #5017:
URL: https://github.com/apache/kyuubi/pull/5017#discussion_r1252589882
##########
extensions/spark/kyuubi-spark-connector-hive/src/main/scala/org/apache/kyuubi/spark/connector/hive/read/HiveScan.scala:
##########
@@ -54,6 +54,14 @@ case class HiveScan(
private val partFileToHivePartMap: mutable.Map[PartitionedFile, HivePartition] = mutable.Map()
+ override def isSplitable(path: Path): Boolean = {
+ catalogTable.provider.map(_.toUpperCase(Locale.ROOT)).exists {
Review Comment:
Does this support non-datasource tables, such as hive serde ?
https://github.com/apache/spark/blob/531ec8bddc8dd22ca39486dbdd31e62e989ddc15/sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveStrategies.scala#L212-L216
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] pan3793 commented on a diff in pull request #5017: [KSHC] Support Parquet/Orc provider is splitable
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on code in PR #5017:
URL: https://github.com/apache/kyuubi/pull/5017#discussion_r1251760695
##########
extensions/spark/kyuubi-spark-connector-hive/src/main/scala/org/apache/kyuubi/spark/connector/hive/read/HiveScan.scala:
##########
@@ -54,6 +54,14 @@ case class HiveScan(
private val partFileToHivePartMap: mutable.Map[PartitionedFile, HivePartition] = mutable.Map()
+ override def isSplitable(path: Path): Boolean = {
+ catalogTable.provider.exists(_.toUpperCase(Locale.ROOT) match {
+ case "PARQUET" => true
+ case "ORC" => true
+ case _ => super.isSplitable(path)
+ })
Review Comment:
```suggestion
catalogTable.provider.map(_.toUpperCase(Locale.ROOT)).exists {
case "PARQUET" => true
case "ORC" => true
case _ => super.isSplitable(path)
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] Yikf commented on pull request #5017: [KSHC] Support Parquet/Orc provider is splitable
Posted by "Yikf (via GitHub)" <gi...@apache.org>.
Yikf commented on PR #5017:
URL: https://github.com/apache/kyuubi/pull/5017#issuecomment-1619897599
> Another question not related to this PR, what's the output filename pattern written by this connector? does it have `.<codec>.<format>` suffix? e.g. `.gzip.parquet`
Like Spark Hive v1, it has no suffix
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] Yikf commented on pull request #5017: [KSHC] Support Parquet/Orc provider is splitable
Posted by "Yikf (via GitHub)" <gi...@apache.org>.
Yikf commented on PR #5017:
URL: https://github.com/apache/kyuubi/pull/5017#issuecomment-1623499923
Thanks all, merged to master
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] Yikf commented on pull request #5017: [KSHC] Support Parquet/Orc provider is splitable
Posted by "Yikf (via GitHub)" <gi...@apache.org>.
Yikf commented on PR #5017:
URL: https://github.com/apache/kyuubi/pull/5017#issuecomment-1623427021
Kindly ping @pan3793 @cxzl25 , Any comments?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org