[GitHub] [iceberg] szehon-ho commented on pull request #2240: Auto promote sorted column metrics to truncate(16)

[GitBox <gi...@apache.org>]

szehon-ho commented on pull request #2240:
URL: https://github.com/apache/iceberg/pull/2240#issuecomment-787059052


   Thanks guys for the time and discussion (learning a lot on the side).
   
   If I understand correctly, it looks metrics-promotion on read is the way to go due to simplicity, esp in regards to alter table not having to alter auto-promoted metrics properties.  But in this approach we have to manually pass in sortOrder in all places of write, and I missed it in the new SparkTableUtil and Flink, which I can add.
   
   I am wondering (being a better code aside), for this particular change what's the use-case covered by passing SortOrder instead of the latest table's sorted column names , auto-promotion of sorted columns would work given just the current sorted names, or no?  I agree SortOrder is less hacky, but just to check my understanding, thanks, 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org