[GitHub] [yunikorn-k8shim] zhuqi-lucas commented on pull request #582: [YUNIKORN-1712] Placeholder allocations are being removed twice

["zhuqi-lucas (via GitHub)" <gi...@apache.org>]

zhuqi-lucas commented on PR #582:
URL: https://github.com/apache/yunikorn-k8shim/pull/582#issuecomment-1530830961

   @craigcondit @wilfred-s 
   
   **Conclusion:**
   The pod eventhandler updatepod and deletepod will all be called, so it will complete task twice for release allocations.
   
   Deleting a pod will not directly trigger the updatePod function in the event handler. Instead, deleting a pod will trigger the deletePod function in the scheduler event handler.
   
   The deletePod function is responsible for removing the pod from the YuniKorn scheduler's internal cache and data structures. This function also updates the status of the application associated with the pod, notifying the YuniKorn scheduler that the resources previously reserved for the pod are now available for allocation to other pods.
   
   However, if the pod is in the process of being deleted, and its status is updated to "Succeeded" or "Failed" by Kubernetes, then this update will trigger the updatePod function in the YuniKorn scheduler event handler. The updatePod function is responsible for updating the internal state of the YuniKorn scheduler with the updated pod status, and for cleaning up any resources associated with the pod.
   
   So, while deleting a pod will not directly trigger the updatePod function, updates to the pod status during the deletion process may trigger it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org