You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2020/12/02 10:16:51 UTC
[GitHub] [tvm] echuraev opened a new pull request #7013: Change default hostname in rpc_tracker
echuraev opened a new pull request #7013:
URL: https://github.com/apache/tvm/pull/7013
This change fix problem with version of IP protocol on MacOS.
Previous the rpc_tracker and query_rpc_tracker were not able connect to
each other with default hostnames.
The root cause was in method `socket.getaddrinfo`. In rpc_tracker the
default hostname was "0.0.0.0" and `getaddrinfo` returned IPv4 type. In
query_rpc_tracker the default hastname is "localhost" and `getaddrinfo`
on MacOS returns IPv6 type. Note: on Linux both have IPv4 type.
These tools worked by different protocols and this is why
query_rpc_tracker wasn't able connect to rpc_tracker.
Now the default hostnames are the same. So it works fine on MacOS.
@tqchen, @jroesch Could you please review it?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] echuraev edited a comment on pull request #7013: Change default hostname in rpc_tracker
Posted by GitBox <gi...@apache.org>.
echuraev edited a comment on pull request #7013:
URL: https://github.com/apache/tvm/pull/7013#issuecomment-737682281
I've updated the PR. Now we will prefer IPv4 type of IP protocol between IPv4 and IPv6. @tqchen please, take a look on it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] echuraev commented on pull request #7013: Change default hostname in rpc_tracker
Posted by GitBox <gi...@apache.org>.
echuraev commented on pull request #7013:
URL: https://github.com/apache/tvm/pull/7013#issuecomment-737143035
And just a question to this PR. Maybe the better option is to set IPv4 type for all rpc connections? Or sometimes it is reasonable to have IPv6?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] echuraev commented on pull request #7013: Change default hostname in rpc_tracker
Posted by GitBox <gi...@apache.org>.
echuraev commented on pull request #7013:
URL: https://github.com/apache/tvm/pull/7013#issuecomment-737682281
I've updated the PR. Now we will prefer IPv4 type of IP protocol between IPv4 and IPv6.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] tqchen commented on a change in pull request #7013: Change default hostname in rpc_tracker
Posted by GitBox <gi...@apache.org>.
tqchen commented on a change in pull request #7013:
URL: https://github.com/apache/tvm/pull/7013#discussion_r534182868
##########
File path: python/tvm/exec/rpc_tracker.py
##########
@@ -33,7 +33,7 @@ def main(args):
if __name__ == "__main__":
parser = argparse.ArgumentParser()
- parser.add_argument("--host", type=str, default="0.0.0.0", help="the hostname of the tracker")
+ parser.add_argument("--host", type=str, default="localhost", help="the hostname of the tracker")
Review comment:
This might prevent rpc tracker from being used other than local host
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] echuraev commented on pull request #7013: Change default hostname in rpc_tracker
Posted by GitBox <gi...@apache.org>.
echuraev commented on pull request #7013:
URL: https://github.com/apache/tvm/pull/7013#issuecomment-738243984
CI is green. @tqchen, could you please take a look on this PR once again?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] tqchen merged pull request #7013: Change default hostname in rpc_tracker
Posted by GitBox <gi...@apache.org>.
tqchen merged pull request #7013:
URL: https://github.com/apache/tvm/pull/7013
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] echuraev removed a comment on pull request #7013: Change default hostname in rpc_tracker
Posted by GitBox <gi...@apache.org>.
echuraev removed a comment on pull request #7013:
URL: https://github.com/apache/tvm/pull/7013#issuecomment-738243984
CI is green. @tqchen, could you please take a look on this PR once again?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] tqchen commented on pull request #7013: Change default hostname in rpc_tracker
Posted by GitBox <gi...@apache.org>.
tqchen commented on pull request #7013:
URL: https://github.com/apache/tvm/pull/7013#issuecomment-737244613
Thanks @echuraev It is indeed good to support IPv6, although the current change could make rpc tracker unavailable from other machines. The second best option is indeed to check and use 0.0.0.0 for now if the default one is ipv6
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org