You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@royale.apache.org by pe...@apache.org on 2018/01/09 22:11:10 UTC

[royale-asjs] branch develop updated: Corrects the slider thumb position based on the mouse.

This is an automated email from the ASF dual-hosted git repository.

pent pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/royale-asjs.git


The following commit(s) were added to refs/heads/develop by this push:
     new be80c93  Corrects the slider thumb position based on the mouse.
be80c93 is described below

commit be80c936c26990bd43d484e1b748701acdcdf48b
Author: Peter Ent <pe...@apache.org>
AuthorDate: Tue Jan 9 17:12:45 2018 -0500

    Corrects the slider thumb position based on the mouse.
---
 .../apache/royale/html/beads/controllers/HSliderMouseController.as  | 6 ++++--
 .../apache/royale/html/beads/controllers/VSliderMouseController.as  | 6 ++++--
 2 files changed, 8 insertions(+), 4 deletions(-)

diff --git a/frameworks/projects/Basic/src/main/royale/org/apache/royale/html/beads/controllers/HSliderMouseController.as b/frameworks/projects/Basic/src/main/royale/org/apache/royale/html/beads/controllers/HSliderMouseController.as
index b36710a..9f8c606 100644
--- a/frameworks/projects/Basic/src/main/royale/org/apache/royale/html/beads/controllers/HSliderMouseController.as
+++ b/frameworks/projects/Basic/src/main/royale/org/apache/royale/html/beads/controllers/HSliderMouseController.as
@@ -228,7 +228,7 @@ package org.apache.royale.html.beads.controllers
 			goog.events.listen(host.element, goog.events.EventType.MOUSELEAVE,
 				handleThumbLeave, false, this);
             
-            mouseOrigin = bevent.clientX;
+            mouseOrigin = bevent.screenX; //.clientX;
             thumbOrigin = parseInt(thumb.element.style.left, 10);
             oldValue = rangeModel.value;
         }
@@ -294,7 +294,9 @@ package org.apache.royale.html.beads.controllers
         COMPILE::JS
         private function calcValFromMousePosition(event:BrowserEvent, useOffset:Boolean):void
         {
-            var deltaX:Number = (useOffset ? event.offsetX : event.clientX) - mouseOrigin;
+            var deltaX:Number = event.screenX - mouseOrigin;//(useOffset ? event.offsetX : event.clientX) - mouseOrigin;
+			if (deltaX == 0) return;
+			
             var thumbW:int = parseInt(thumb.element.style.width, 10) / 2;
             var newX:Number = thumbOrigin + deltaX;
 			var newPointX:Number = newX + thumbW; // center of the thumb which represents the value
diff --git a/frameworks/projects/Basic/src/main/royale/org/apache/royale/html/beads/controllers/VSliderMouseController.as b/frameworks/projects/Basic/src/main/royale/org/apache/royale/html/beads/controllers/VSliderMouseController.as
index 5a46474..fff4817 100644
--- a/frameworks/projects/Basic/src/main/royale/org/apache/royale/html/beads/controllers/VSliderMouseController.as
+++ b/frameworks/projects/Basic/src/main/royale/org/apache/royale/html/beads/controllers/VSliderMouseController.as
@@ -216,7 +216,7 @@ package org.apache.royale.html.beads.controllers
 			goog.events.listen(host.element, goog.events.EventType.MOUSELEAVE,
 				handleThumbLeave, false, this);
 			
-			mouseOrigin = bevent.clientY;
+			mouseOrigin = bevent.screenY; //.clientY;
 			thumbOrigin = parseInt(thumb.element.style.top, 10);
 			oldValue = rangeModel.value;
 		}
@@ -278,7 +278,9 @@ package org.apache.royale.html.beads.controllers
 		COMPILE::JS
 		private function calcValFromMousePosition(event:BrowserEvent, useOffset:Boolean):void
 		{
-			var deltaY:Number = (useOffset ? event.offsetY : event.clientY) - mouseOrigin;
+			var deltaY:Number = event.screenY - mouseOrigin; //(useOffset ? event.offsetY : event.clientY) - mouseOrigin;
+			if (deltaY == 0) return;
+			
 			var thumbH:int = parseInt(thumb.element.style.height, 10) / 2;
 			var newY:Number = thumbOrigin + deltaY;
 			var newPointY:Number = newY + thumbH; // center of the thumb which represents the value

-- 
To stop receiving notification emails like this one, please contact
['"commits@royale.apache.org" <co...@royale.apache.org>'].