You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@polygene.apache.org by "Paul Merlin (JIRA)" <ji...@apache.org> on 2016/11/07 14:03:58 UTC
[jira] [Resolved] (ZEST-190) Refine Metrics API/SPI
[ https://issues.apache.org/jira/browse/ZEST-190?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Paul Merlin resolved ZEST-190.
------------------------------
Resolution: Fixed
Naming metrics is an application concern, the Metrics API now only require a single String for metrics names and provide a helper to build metric names using "structure paths".
Both the built in {{UnitOfWork}} metrics and the {{metrics}} library produce "structure path" based names using the added helper.
Along the way I fixed the existing metrics tests flakiness. We should not see any more randomly failed tests on CI.
This is now on {{develop}}, resolving the issue.
> Refine Metrics API/SPI
> ----------------------
>
> Key: ZEST-190
> URL: https://issues.apache.org/jira/browse/ZEST-190
> Project: Zest
> Issue Type: Improvement
> Reporter: Paul Merlin
> Assignee: Paul Merlin
> Fix For: 3.0
>
>
> The current metrics API mixes in pure metrics aspects with reporting ones. The factories should not require the reporting duration unit nor the rate unit nor display names. These should be chosen when using reporters, whatever the metrics collection backend.
> Let's use {{Stream<Metric>}} instead of {{Iterable}} in {{MetricsFactory::registered()}}.
> {{@TimingCapture}} concern should name timers with some "Structure path" by default, like we do in jmx support, and allow to name the underlying timer with an annotation parameter.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)