[GitHub] [arrow] vibhatha commented on a change in pull request #12110: Arrow 15212: [C++] Handle suffix argument in joins

[GitBox <gi...@apache.org>]

vibhatha commented on a change in pull request #12110:
URL: https://github.com/apache/arrow/pull/12110#discussion_r781680540



##########
File path: cpp/src/arrow/compute/exec/hash_join_node.cc
##########
@@ -294,8 +294,7 @@ std::shared_ptr<Schema> HashJoinSchema::MakeOutputSchema(
         proj_maps[side].data_type(HashJoinProjection::INPUT, input_field_id);
 
     std::string output_field_name =
-        (is_left ? left_field_name_prefix : right_field_name_prefix) + input_field_name;
-
+        input_field_name + (is_left ? left_field_name_prefix : right_field_name_prefix);

Review comment:
       Yes, I think there are a few used in a few places that I have missed. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org