You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2020/08/31 07:54:55 UTC
[GitHub] [hadoop-ozone] cku328 opened a new pull request #1367: HDDS-4169. Fix some minor errors in StorageContainerManager.md
cku328 opened a new pull request #1367:
URL: https://github.com/apache/hadoop-ozone/pull/1367
## What changes were proposed in this pull request?
Fixed typo and removed duplicate title bar.
## What is the link to the Apache JIRA
https://issues.apache.org/jira/projects/HDDS/issues/HDDS-4169
## How was this patch tested?
It's not necessary.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] cxorm commented on pull request #1367: HDDS-4169. Fix some minor errors in StorageContainerManager.md
Posted by GitBox <gi...@apache.org>.
cxorm commented on pull request #1367:
URL: https://github.com/apache/hadoop-ozone/pull/1367#issuecomment-686230402
Thank you @amaliujia for reviewing this PR and @cku328 for contributing it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] cxorm commented on pull request #1367: HDDS-4169. Fix some minor errors in StorageContainerManager.md
Posted by GitBox <gi...@apache.org>.
cxorm commented on pull request #1367:
URL: https://github.com/apache/hadoop-ozone/pull/1367#issuecomment-685254966
The failed `build-branch / unit (pull_request)` seems not related the patch.
Let's commit it again.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] amaliujia commented on a change in pull request #1367: HDDS-4169. Fix some minor errors in StorageContainerManager.md
Posted by GitBox <gi...@apache.org>.
amaliujia commented on a change in pull request #1367:
URL: https://github.com/apache/hadoop-ozone/pull/1367#discussion_r480480468
##########
File path: hadoop-hdds/docs/content/concept/StorageContainerManager.md
##########
@@ -46,7 +46,7 @@ replicas. If there is a loss of data node or a disk, SCM
detects it and instructs data nodes make copies of the
missing blocks to ensure high availability.
- 3. **SCM's Ceritificate authority** is in
+ 3. **SCM's Certificate authority** is in
Review comment:
Should it be both upper case or lower case for the first character?
E.g. either `Certificate Authority` or `certificate authority`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] cxorm merged pull request #1367: HDDS-4169. Fix some minor errors in StorageContainerManager.md
Posted by GitBox <gi...@apache.org>.
cxorm merged pull request #1367:
URL: https://github.com/apache/hadoop-ozone/pull/1367
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] amaliujia commented on pull request #1367: HDDS-4169. Fix some minor errors in StorageContainerManager.md
Posted by GitBox <gi...@apache.org>.
amaliujia commented on pull request #1367:
URL: https://github.com/apache/hadoop-ozone/pull/1367#issuecomment-684161934
Thanks! LGTM
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] cku328 commented on a change in pull request #1367: HDDS-4169. Fix some minor errors in StorageContainerManager.md
Posted by GitBox <gi...@apache.org>.
cku328 commented on a change in pull request #1367:
URL: https://github.com/apache/hadoop-ozone/pull/1367#discussion_r480582833
##########
File path: hadoop-hdds/docs/content/concept/StorageContainerManager.md
##########
@@ -46,7 +46,7 @@ replicas. If there is a loss of data node or a disk, SCM
detects it and instructs data nodes make copies of the
missing blocks to ensure high availability.
- 3. **SCM's Ceritificate authority** is in
+ 3. **SCM's Certificate authority** is in
Review comment:
Thanks @amaliujia for the suggestion. Both names sound good to me.
I'll update the patch based on your suggestion.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] cku328 commented on pull request #1367: HDDS-4169. Fix some minor errors in StorageContainerManager.md
Posted by GitBox <gi...@apache.org>.
cku328 commented on pull request #1367:
URL: https://github.com/apache/hadoop-ozone/pull/1367#issuecomment-685565497
Thanks @cxorm & @amaliujia for the review.
Now the CI check has passed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org