[jira] [Commented] (CALCITE-553) "mvn clean install" fails due to missing SqlParserImpl

["Josh Elser (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CALCITE-553?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15140408#comment-15140408 ] 

Josh Elser commented on CALCITE-553:
------------------------------------

I think this is ultimately boiling down to the profile activation check happening before the clean phase runs. The profile isn't activated because core/target/generated-sources/fmpp/javacc/Parser.jj exists, the clean destroys all of target, fmpp doesn't get re-run, and then the javacc plugin also skips itself because its source directory (the fmpp output) doesn't exist.

I can understand the worth in trying to get incremental compliation and faster builds, but it really bothers me when it comes at the cost of breaking the expected semantics of the build tool. I'll see if there's some kind of trick I can find to work around this, but, if I can't figure something out, I'm going to suggest we remove the activation block (and run it all the time).

> "mvn clean install" fails due to missing SqlParserImpl
> ------------------------------------------------------
>
>                 Key: CALCITE-553
>                 URL: https://issues.apache.org/jira/browse/CALCITE-553
>             Project: Calcite
>          Issue Type: Bug
>            Reporter: Julian Hyde
>            Assignee: Vladimir Sitnikov
>
> Every second time I call {mvn -DskipTests clean install} it fails with
> {code}[ERROR] COMPILATION ERROR : 
> [INFO] -------------------------------------------------------------
> [ERROR] /home/jhyde/open1/calcite.2/core/src/main/java/org/apache/calcite/sql/parser/SqlParser.java:[24,42] cannot find symbol
>   symbol:   class SqlParserImpl
>   location: package org.apache.calcite.sql.parser.impl
> [ERROR] /home/jhyde/open1/calcite.2/core/src/main/java/org/apache/calcite/sql/parser/SqlParser.java:[201,50] cannot find symbol
>   symbol:   variable SqlParserImpl
>   location: class org.apache.calcite.sql.parser.SqlParser.ConfigBuilder
> [INFO] 2 errors{code}
> I think CALCITE-484 broke something; maybe the parser is not generated correctly if at the start of the mvn command (before clean) the parser already exists.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)