[jira] [Commented] (AVRO-1434) ObjectCreator.cs is not thread safe

["ASF subversion and git services (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AVRO-1434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13868286#comment-13868286 ] 

ASF subversion and git services commented on AVRO-1434:
-------------------------------------------------------

Commit 1557250 from [~cutting] in branch 'avro/trunk'
[ https://svn.apache.org/r1557250 ]

AVRO-1434. C#: Fix ObjectCreator to be thread safe.  Contributed by David Taylor.

> ObjectCreator.cs is not thread safe
> -----------------------------------
>
>                 Key: AVRO-1434
>                 URL: https://issues.apache.org/jira/browse/AVRO-1434
>             Project: Avro
>          Issue Type: Bug
>          Components: csharp
>    Affects Versions: 1.7.5
>         Environment: Windows
>            Reporter: David Taylor
>            Assignee: David Taylor
>             Fix For: 1.7.6
>
>         Attachments: ObjectCreator.cs.diff
>
>
> Public methods ObjectCreator.GetType() assign to shared fields without locks.  This causes unpredictable behaviour in a multi-threaded application.  The easiest fix is to simply remove the shared variables as they appear to exist as a potential performance improvement but constructing local variables seems to add no significant overhead.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)