You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by "An-DJ (via GitHub)" <gi...@apache.org> on 2023/03/13 01:53:15 UTC
[GitHub] [apisix] An-DJ opened a new issue, #9055: bug: If `allow_admin` contains 127.0.0.0/24, requests from other ips without adminKey are allowed by default
An-DJ opened a new issue, #9055:
URL: https://github.com/apache/apisix/issues/9055
### Current Behavior
If `allow_admin` contains 127.0.0.0/24, requests from other ips without the admin key are allowed by default.
https://github.com/apache/apisix/blob/27535e9831b303ef721046bd51e471abb0be9c13/apisix/cli/ops.lua#L190
### Expected Behavior
Only requests from 127.0.0.0/24 without adminKey are allowed. Otherwise, they should be banned if the admin key isn't configured in `config.yaml`.
### Error Logs
_No response_
### Steps to Reproduce
1. use the config below:
```
deployment:
admin:
allow_admin:
- 0.0.0.0/0
- 127.0.0.0/24
```
2. Requests from other ips without configuring and using adminKey are allowed.
### Environment
- APISIX version (run `apisix version`): 3.2.0
- Operating system (run `uname -a`): Ubuntu 18.04
- OpenResty / Nginx version (run `openresty -V` or `nginx -V`):
- etcd version, if relevant (run `curl http://127.0.0.1:9090/v1/server_info`):
- APISIX Dashboard version, if relevant:
- Plugin runner version, for issues related to plugin runners:
- LuaRocks version, for installation issues (run `luarocks --version`):
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] monkeyDluffy6017 closed issue #9055: bug: If `allow_admin` contains 127.0.0.0/24, requests from other ips without adminKey are allowed by default
Posted by "monkeyDluffy6017 (via GitHub)" <gi...@apache.org>.
monkeyDluffy6017 closed issue #9055: bug: If `allow_admin` contains 127.0.0.0/24, requests from other ips without adminKey are allowed by default
URL: https://github.com/apache/apisix/issues/9055
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander commented on issue #9055: bug: If `allow_admin` contains 127.0.0.0/24, requests from other ips without adminKey are allowed by default
Posted by "spacewander (via GitHub)" <gi...@apache.org>.
spacewander commented on issue #9055:
URL: https://github.com/apache/apisix/issues/9055#issuecomment-1465407486
It looks like it just avoids warnings when using the default configuration. But the judgment is faulty and should see if it is only "127.0.0.0/24".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org