[GitHub] [pulsar] sijie commented on a change in pull request #3853: [Issue 3851] [pulsar-broker] Support to start broker use the port initialized in cluster metadata

[GitBox <gi...@apache.org>]

sijie commented on a change in pull request #3853: [Issue 3851] [pulsar-broker] Support to start broker use the port initialized in cluster metadata
URL: https://github.com/apache/pulsar/pull/3853#discussion_r266549572
 
 

 ##########
 File path: pulsar-broker/src/main/java/org/apache/pulsar/PulsarBrokerStarter.java
 ##########
 @@ -110,6 +115,23 @@ private static boolean argsContains(String[] args, String arg) {
         return Arrays.asList(args).contains(arg);
     }
 
+    private static ClusterData retrieveClusterData(ServiceConfiguration config) throws Exception {
+        String configurationStoreServers = config.getConfigurationStoreServers();
+        Long zkSessionTimeoutMillis = config.getZooKeeperSessionTimeoutMillis();
+        String clusterName = config.getClusterName();
+        ZooKeeperClientFactory zkfactory = new ZookeeperClientFactoryImpl();
+        ZooKeeper configStoreZk = zkfactory.create(
 
 Review comment:
   close zookeeper at the end to release resources

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services