[jira] Issue Comment Edited: (WICKET-3075) AJAX file upload fails in IE8 due to Wicket.Ajax.handleMultipart() sniffing wicket:body tags as an HTML body element when running Wicket in development mode

["Martin Grigorov (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/WICKET-3075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12914940#action_12914940 ] 

Martin Grigorov edited comment on WICKET-3075 at 9/27/10 4:29 AM:
------------------------------------------------------------------

Improved with r1001387 (trunk) and r1001388 (1.4.x).
Tested on FF3.6.11pre, FF4 beta, Opera 10.62, Chrome 7.x, IE7 and IE8.

      was (Author: mgrigorov):
    Improved with r1001387 (trunk) and r1001388 (1.4.x).
Tested on FF3.6.11pre, FF4 beta, Opera 10.62 and Chrome 7.x.
  
> AJAX file upload fails in IE8 due to Wicket.Ajax.handleMultipart() sniffing wicket:body tags as an HTML body element when running Wicket in development mode
> ------------------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: WICKET-3075
>                 URL: https://issues.apache.org/jira/browse/WICKET-3075
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 1.4.10
>            Reporter: Liam Clarke-Hutchinson
>            Assignee: Martin Grigorov
>            Priority: Minor
>             Fix For: 1.4.13, 1.5-M3
>
>         Attachments: bodySniffing.patch, reproduction_body_bug.zip
>
>
> To reproduce:
> 1. Run provided quickstart project
> 2. Open in IE8. 
> 3. Upload a file. 
> Expected behaviour: 
> File is uploaded, and some basic information about uploaded file is displayed.
> Observed behaviour:
> IllegalStateException is thrown.
> The IllegalStateException is being thrown because the form is being submitted as a normal form. This is because the JS in handleMultipart that traverses up the DOM looking for the actual form is checking tagnames, and in IE8, the tagName of a <wicket:body> is body, so as soon as it hits a wicket:body, it returns false. I've provided a patch that checks for identity against document.body - an alternative is to check that the form.tagUrn is empty, as it would be for a normal HTML element. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.