You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by "Koji Noguchi (JIRA)" <ji...@apache.org> on 2008/03/21 23:29:24 UTC
[jira] Created: (HADOOP-3070) Trash not being expunged, Trash
Emptier thread gone by NPE
Trash not being expunged, Trash Emptier thread gone by NPE
----------------------------------------------------------
Key: HADOOP-3070
URL: https://issues.apache.org/jira/browse/HADOOP-3070
Project: Hadoop Core
Issue Type: Bug
Components: fs
Affects Versions: 0.16.1, 0.16.0
Reporter: Koji Noguchi
We noticed that the users' trash were not being expunged by the namenode.
jstack didn't show the Trash.Emptier thread and .out file showed
Exception in thread "Trash Emptier" java.lang.NullPointerException
at org.apache.hadoop.fs.Trash.expunge(Trash.java:146)
at org.apache.hadoop.fs.Trash$Emptier.run(Trash.java:233)
at java.lang.Thread.run(Thread.java:619)
It seems like this happens when it hits the user's directory which doesn't contain the .Trash.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-3070) Trash not being expunged, Trash
Emptier thread gone by NPE
Posted by "Owen O'Malley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12581243#action_12581243 ]
Owen O'Malley commented on HADOOP-3070:
---------------------------------------
+1 for 16.2
I would also add a catch at the outer level of the run method to catch runtime exceptions.
> Trash not being expunged, Trash Emptier thread gone by NPE
> ----------------------------------------------------------
>
> Key: HADOOP-3070
> URL: https://issues.apache.org/jira/browse/HADOOP-3070
> Project: Hadoop Core
> Issue Type: Bug
> Components: fs
> Affects Versions: 0.16.0, 0.16.1
> Reporter: Koji Noguchi
> Fix For: 0.16.2
>
> Attachments: H3070.0.16.1.patch
>
>
> We noticed that the users' trash were not being expunged by the namenode.
> jstack didn't show the Trash.Emptier thread and .out file showed
> Exception in thread "Trash Emptier" java.lang.NullPointerException
> at org.apache.hadoop.fs.Trash.expunge(Trash.java:146)
> at org.apache.hadoop.fs.Trash$Emptier.run(Trash.java:233)
> at java.lang.Thread.run(Thread.java:619)
> It seems like this happens when it hits the user's directory which doesn't contain the .Trash.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-3070) Trash not being expunged, Trash
Emptier thread gone by NPE
Posted by "Nigel Daley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12581246#action_12581246 ]
Nigel Daley commented on HADOOP-3070:
-------------------------------------
Thanks for the patch Koji. This patch needs a test case in TestTrash.java. As well, can someone code review the HADOOP-2514 patch that implemented this feature to see if there are other issues with it? It was committed without a code review. Sigh.
> Trash not being expunged, Trash Emptier thread gone by NPE
> ----------------------------------------------------------
>
> Key: HADOOP-3070
> URL: https://issues.apache.org/jira/browse/HADOOP-3070
> Project: Hadoop Core
> Issue Type: Bug
> Components: fs
> Affects Versions: 0.16.0, 0.16.1
> Reporter: Koji Noguchi
> Fix For: 0.16.2
>
> Attachments: H3070.0.16.1.patch
>
>
> We noticed that the users' trash were not being expunged by the namenode.
> jstack didn't show the Trash.Emptier thread and .out file showed
> Exception in thread "Trash Emptier" java.lang.NullPointerException
> at org.apache.hadoop.fs.Trash.expunge(Trash.java:146)
> at org.apache.hadoop.fs.Trash$Emptier.run(Trash.java:233)
> at java.lang.Thread.run(Thread.java:619)
> It seems like this happens when it hits the user's directory which doesn't contain the .Trash.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-3070) Trash not being expunged, Trash
Emptier thread gone by NPE
Posted by "Owen O'Malley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3070?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Owen O'Malley updated HADOOP-3070:
----------------------------------
Assignee: Koji Noguchi
Status: Patch Available (was: Open)
> Trash not being expunged, Trash Emptier thread gone by NPE
> ----------------------------------------------------------
>
> Key: HADOOP-3070
> URL: https://issues.apache.org/jira/browse/HADOOP-3070
> Project: Hadoop Core
> Issue Type: Bug
> Components: fs
> Affects Versions: 0.16.1, 0.16.0
> Reporter: Koji Noguchi
> Assignee: Koji Noguchi
> Priority: Blocker
> Fix For: 0.16.2
>
> Attachments: H3070.0.16.1-2.patch, H3070.0.16.1.patch
>
>
> We noticed that the users' trash were not being expunged by the namenode.
> jstack didn't show the Trash.Emptier thread and .out file showed
> Exception in thread "Trash Emptier" java.lang.NullPointerException
> at org.apache.hadoop.fs.Trash.expunge(Trash.java:146)
> at org.apache.hadoop.fs.Trash$Emptier.run(Trash.java:233)
> at java.lang.Thread.run(Thread.java:619)
> It seems like this happens when it hits the user's directory which doesn't contain the .Trash.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-3070) Trash not being expunged, Trash
Emptier thread gone by NPE
Posted by "Koji Noguchi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3070?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Koji Noguchi updated HADOOP-3070:
---------------------------------
Attachment: H3070.0.16.1-2.patch
Owen, added a try-catch for RuntimeException.
I wasn't sure where I should put.
Nigel, added one test for -expunge on an empty user dir.
> Trash not being expunged, Trash Emptier thread gone by NPE
> ----------------------------------------------------------
>
> Key: HADOOP-3070
> URL: https://issues.apache.org/jira/browse/HADOOP-3070
> Project: Hadoop Core
> Issue Type: Bug
> Components: fs
> Affects Versions: 0.16.0, 0.16.1
> Reporter: Koji Noguchi
> Fix For: 0.16.2
>
> Attachments: H3070.0.16.1-2.patch, H3070.0.16.1.patch
>
>
> We noticed that the users' trash were not being expunged by the namenode.
> jstack didn't show the Trash.Emptier thread and .out file showed
> Exception in thread "Trash Emptier" java.lang.NullPointerException
> at org.apache.hadoop.fs.Trash.expunge(Trash.java:146)
> at org.apache.hadoop.fs.Trash$Emptier.run(Trash.java:233)
> at java.lang.Thread.run(Thread.java:619)
> It seems like this happens when it hits the user's directory which doesn't contain the .Trash.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-3070) Trash not being expunged, Trash
Emptier thread gone by NPE
Posted by "Koji Noguchi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3070?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Koji Noguchi updated HADOOP-3070:
---------------------------------
Fix Version/s: 0.16.2
I think this needs to be in 0.16.2.
> Trash not being expunged, Trash Emptier thread gone by NPE
> ----------------------------------------------------------
>
> Key: HADOOP-3070
> URL: https://issues.apache.org/jira/browse/HADOOP-3070
> Project: Hadoop Core
> Issue Type: Bug
> Components: fs
> Affects Versions: 0.16.0, 0.16.1
> Reporter: Koji Noguchi
> Fix For: 0.16.2
>
> Attachments: H3070.0.16.1.patch
>
>
> We noticed that the users' trash were not being expunged by the namenode.
> jstack didn't show the Trash.Emptier thread and .out file showed
> Exception in thread "Trash Emptier" java.lang.NullPointerException
> at org.apache.hadoop.fs.Trash.expunge(Trash.java:146)
> at org.apache.hadoop.fs.Trash$Emptier.run(Trash.java:233)
> at java.lang.Thread.run(Thread.java:619)
> It seems like this happens when it hits the user's directory which doesn't contain the .Trash.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-3070) Trash not being expunged, Trash
Emptier thread gone by NPE
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12582616#action_12582616 ]
Hudson commented on HADOOP-3070:
--------------------------------
Integrated in Hadoop-trunk #443 (See [http://hudson.zones.apache.org/hudson/job/Hadoop-trunk/443/])
> Trash not being expunged, Trash Emptier thread gone by NPE
> ----------------------------------------------------------
>
> Key: HADOOP-3070
> URL: https://issues.apache.org/jira/browse/HADOOP-3070
> Project: Hadoop Core
> Issue Type: Bug
> Components: fs
> Affects Versions: 0.16.0, 0.16.1
> Reporter: Koji Noguchi
> Assignee: Koji Noguchi
> Priority: Blocker
> Fix For: 0.16.2
>
> Attachments: H3070.0.16.1-2.patch, H3070.0.16.1.patch
>
>
> We noticed that the users' trash were not being expunged by the namenode.
> jstack didn't show the Trash.Emptier thread and .out file showed
> Exception in thread "Trash Emptier" java.lang.NullPointerException
> at org.apache.hadoop.fs.Trash.expunge(Trash.java:146)
> at org.apache.hadoop.fs.Trash$Emptier.run(Trash.java:233)
> at java.lang.Thread.run(Thread.java:619)
> It seems like this happens when it hits the user's directory which doesn't contain the .Trash.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-3070) Trash not being expunged, Trash
Emptier thread gone by NPE
Posted by "Robert Chansler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3070?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robert Chansler updated HADOOP-3070:
------------------------------------
Priority: Blocker (was: Major)
> Trash not being expunged, Trash Emptier thread gone by NPE
> ----------------------------------------------------------
>
> Key: HADOOP-3070
> URL: https://issues.apache.org/jira/browse/HADOOP-3070
> Project: Hadoop Core
> Issue Type: Bug
> Components: fs
> Affects Versions: 0.16.0, 0.16.1
> Reporter: Koji Noguchi
> Priority: Blocker
> Fix For: 0.16.2
>
> Attachments: H3070.0.16.1-2.patch, H3070.0.16.1.patch
>
>
> We noticed that the users' trash were not being expunged by the namenode.
> jstack didn't show the Trash.Emptier thread and .out file showed
> Exception in thread "Trash Emptier" java.lang.NullPointerException
> at org.apache.hadoop.fs.Trash.expunge(Trash.java:146)
> at org.apache.hadoop.fs.Trash$Emptier.run(Trash.java:233)
> at java.lang.Thread.run(Thread.java:619)
> It seems like this happens when it hits the user's directory which doesn't contain the .Trash.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-3070) Trash not being expunged, Trash
Emptier thread gone by NPE
Posted by "Owen O'Malley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3070?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Owen O'Malley updated HADOOP-3070:
----------------------------------
Resolution: Fixed
Status: Resolved (was: Patch Available)
I just committed this. Thanks, Koji.
> Trash not being expunged, Trash Emptier thread gone by NPE
> ----------------------------------------------------------
>
> Key: HADOOP-3070
> URL: https://issues.apache.org/jira/browse/HADOOP-3070
> Project: Hadoop Core
> Issue Type: Bug
> Components: fs
> Affects Versions: 0.16.0, 0.16.1
> Reporter: Koji Noguchi
> Assignee: Koji Noguchi
> Priority: Blocker
> Fix For: 0.16.2
>
> Attachments: H3070.0.16.1-2.patch, H3070.0.16.1.patch
>
>
> We noticed that the users' trash were not being expunged by the namenode.
> jstack didn't show the Trash.Emptier thread and .out file showed
> Exception in thread "Trash Emptier" java.lang.NullPointerException
> at org.apache.hadoop.fs.Trash.expunge(Trash.java:146)
> at org.apache.hadoop.fs.Trash$Emptier.run(Trash.java:233)
> at java.lang.Thread.run(Thread.java:619)
> It seems like this happens when it hits the user's directory which doesn't contain the .Trash.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-3070) Trash not being expunged, Trash
Emptier thread gone by NPE
Posted by "Koji Noguchi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3070?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Koji Noguchi updated HADOOP-3070:
---------------------------------
Attachment: H3070.0.16.1.patch
simple null check.
> Trash not being expunged, Trash Emptier thread gone by NPE
> ----------------------------------------------------------
>
> Key: HADOOP-3070
> URL: https://issues.apache.org/jira/browse/HADOOP-3070
> Project: Hadoop Core
> Issue Type: Bug
> Components: fs
> Affects Versions: 0.16.0, 0.16.1
> Reporter: Koji Noguchi
> Attachments: H3070.0.16.1.patch
>
>
> We noticed that the users' trash were not being expunged by the namenode.
> jstack didn't show the Trash.Emptier thread and .out file showed
> Exception in thread "Trash Emptier" java.lang.NullPointerException
> at org.apache.hadoop.fs.Trash.expunge(Trash.java:146)
> at org.apache.hadoop.fs.Trash$Emptier.run(Trash.java:233)
> at java.lang.Thread.run(Thread.java:619)
> It seems like this happens when it hits the user's directory which doesn't contain the .Trash.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.