You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by kiranptivo <gi...@git.apache.org> on 2017/01/14 00:35:29 UTC

[GitHub] kafka pull request #2378: KAFKA-3857 Additional log cleaner metrics

GitHub user kiranptivo opened a pull request:

    https://github.com/apache/kafka/pull/2378

    KAFKA-3857 Additional log cleaner metrics

    Fixes KAFKA-3857
    
    Changes proposed in this pull request:
    
    An additional log cleaner metric has been added:
    time-since-last-run-ms: Time since the last log cleaner run, in milliseconds.  This metric would be reset to 0 every time log cleaner thread runs. If this metric keeps constantly increasing, it indicates that the log cleaner thread is not alive.
    
    If you are creating alerts around log cleaner, you could monitor this metric. A high "time-since-last-run-ms" value (eg: 600000) indicates that the log cleaner hasn't been running since the last 10 minutes.
    
    The code has been tested. JMX metric has been verified.
    
    Note: This pull request is a continuation of the following pull request.  PR#1593 was quite old and I had some trouble rebasing it. Decided to start a fresh PR.
    
    https://github.com/apache/kafka/pull/1593/files/927b28cf41275874945beb7377f7f36c462f27c8#diff-ca1c127eee4b3c748ae73028f6abeab8

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/kiranptivo/kafka log_cleaner_jmx_metric

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/kafka/pull/2378.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2378
    
----
commit a8635ff4a13e66b3f142ad97fff0ab082ecaf466
Author: Kiran Pillarisetty <pi...@tivo.com>
Date:   2017-01-14T00:23:45Z

    Added a new metric time-since-last-run-ms, to track the time since the last log cleaner run, in milli seconds

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] kafka pull request #2378: KAFKA-3857 Additional log cleaner metrics

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/kafka/pull/2378


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---