[GitHub] [hbase] anoopsjohn commented on a change in pull request #626: HBASE-23017 Verify the file integrity in persistent IOEngine

[GitBox <gi...@apache.org>]

anoopsjohn commented on a change in pull request #626: HBASE-23017 Verify the file integrity in persistent IOEngine
URL: https://github.com/apache/hbase/pull/626#discussion_r327726045
 
 

 ##########
 File path: hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/BucketCache.java
 ##########
 @@ -1081,8 +1101,47 @@ private void retrieveFromFile(int[] bucketSizes) throws IOException {
         throw new IOException("Persistence file does not start with protobuf magic number. " +
             persistencePath);
       }
+      byte[] pbuf2 = new byte[pblen];
 
 Review comment:
   All these logic will go away. From the PB message we can get.. So getting back the checksum should be included as part of parsePB()

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services