You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2022/06/13 05:07:57 UTC

[GitHub] [apisix] Jon-Gaara commented on a diff in pull request #7231: fix: grpc-transcode request support object array

Jon-Gaara commented on code in PR #7231:
URL: https://github.com/apache/apisix/pull/7231#discussion_r895330336


##########
apisix/plugins/grpc-transcode/util.lua:
##########
@@ -147,6 +147,22 @@ function _M.map_message(field, default_values, request_table)
         if ty ~= "enum" and field_type:sub(1, 1) == "." then
             if request_table[name] == nil then
                 sub = default_values and default_values[name]
+            elseif core.table.isarray(request_table[name]) then
+                local sub_array = core.table.new(#request_table[name],0)
+                for i,value in ipairs(request_table[name]) do

Review Comment:
   I have modified and submitted,but  the CI not pass



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org