You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/01/15 01:25:36 UTC
[GitHub] [superset] eugeniamz opened a new issue #12531: Filter box should not add random predicate to Select and use the specified predicated in the dataset
eugeniamz opened a new issue #12531:
URL: https://github.com/apache/superset/issues/12531
Filter box does a
```select <field> from datasource```
for each column in the filter box but the queries that execute in the database add a predicated to select everything from the previous date or older
``` select <field> from datasource where <random date column> < 'date 00:00'```
This won't include the new values from the 'today' and scan all the data from the dataset. This full scan in the database can be expensive to the database..
if in the dataset exists the option to predefined a predicated to improve the filters loads performance, we should use the same for the filters box values instead to add a random predicated
**Example to reproduce**
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc commented on issue #12531: [explore]Filter box should use specified predicated time range in the dataset
Posted by GitBox <gi...@apache.org>.
junlincc commented on issue #12531:
URL: https://github.com/apache/superset/issues/12531#issuecomment-760591743
@eugeniamz clear👍, will look into it
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] nikolagigic commented on issue #12531: [explore]Filter box should use specified predicated time range in the dataset
Posted by GitBox <gi...@apache.org>.
nikolagigic commented on issue #12531:
URL: https://github.com/apache/superset/issues/12531#issuecomment-771787696
@eugeniamz @junlincc If I understood this correctly we want to add the predefined **Autocomplete query predicate** in case it exists to the filters query when its ran?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] nikolagigic commented on issue #12531: [explore]Filter box should use specified predicated time range in the dataset
Posted by GitBox <gi...@apache.org>.
nikolagigic commented on issue #12531:
URL: https://github.com/apache/superset/issues/12531#issuecomment-771787696
@eugeniamz @junlincc If I understood this correctly we want to add the predefined **Autocomplete query predicate** in case it exists to the filters query when its ran?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc commented on issue #12531: [explore]Filter box should use specified predicated time range in the dataset
Posted by GitBox <gi...@apache.org>.
junlincc commented on issue #12531:
URL: https://github.com/apache/superset/issues/12531#issuecomment-771088361
@eugeniamz started working on this one, sorry about the delay.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc closed issue #12531: [explore]Filter box should use specified predicated time range in the dataset
Posted by GitBox <gi...@apache.org>.
junlincc closed issue #12531:
URL: https://github.com/apache/superset/issues/12531
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org