[GitHub] [superset] eschutho commented on a diff in pull request #22199: feat(ssh_tunnel): APIs for SSH Tunnels

[GitBox <gi...@apache.org>]

eschutho commented on code in PR #22199:
URL: https://github.com/apache/superset/pull/22199#discussion_r1035429957


##########
superset/databases/api.py:
##########
@@ -1204,3 +1210,58 @@ def validate_parameters(self) -> FlaskResponse:
         command = ValidateDatabaseParametersCommand(payload)
         command.run()
         return self.response(200, message="OK")
+
+    @expose("/<int:pk>/ssh_tunnel/", methods=["DELETE"])
+    @protect()
+    @safe

Review Comment:
   IIRC, we no longer want to use this decorator because we want all errors to raise to be SIP41 compliant. DId I get that right @betodealmeida?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org