[GitHub] [hudi] pan3793 commented on pull request #6240: [HUDI-4482] remove guava and use caffeine instead for cache

["pan3793 (via GitHub)" <gi...@apache.org>]

pan3793 commented on PR #6240:
URL: https://github.com/apache/hudi/pull/6240#issuecomment-1420149952

   Removing Guava from the bundle jar does not make sense IMO, because the third-party libs required by the bundle still may require Guava, like curator.
   
   Specifically, this PR breaks the Zk functionalities, I meet the following error when testing hudi-spark3.3-bundle w/ Kyuubi.
   ```
   Caused by: java.lang.NoClassDefFoundError: org/apache/hudi/com/google/common/base/Preconditions
   	at org.apache.curator.ensemble.fixed.FixedEnsembleProvider.<init>(FixedEnsembleProvider.java:39)
   	at org.apache.curator.framework.CuratorFrameworkFactory$Builder.connectString(CuratorFrameworkFactory.java:193)
   	at org.apache.kyuubi.ha.client.zookeeper.ZookeeperClientProvider$.buildZookeeperClient(ZookeeperClientProvider.scala:62)
   	at org.apache.kyuubi.ha.client.zookeeper.ZookeeperDiscoveryClient.<init>(ZookeeperDiscoveryClient.scala:65)
   	... 45 more
   ```
   
   Further, why bundle jar contains the curator w/the original package name rather than the relocated one?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org