You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/11/19 04:45:03 UTC

[GitHub] [pulsar] lhotari opened a new pull request, #17943: [improve][CI] Speed up execution of OTHER unit test group by removing -DtestReuseFork=false

lhotari opened a new pull request, #17943:
URL: https://github.com/apache/pulsar/pull/17943

   ### Motivation 
   
   using `-DtestReuseFork=false` slows down test execution significantly.
   
   - this was added in https://github.com/apache/pulsar/pull/17049/files#diff-e6ac90fc5f2373a64dc1ecaa11a9c965f9a22f128cc4ca1265972e0dc4fef9c5R137
   
   ### Modifications
   
   remove `-DtestReuseFork=false` for OTHER unit test group
   
   ### Documentation
   
   <!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
   
   - [ ] `doc` <!-- Your PR contains doc changes -->
   - [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
   - [x] `doc-not-needed` <!-- Your PR changes do not impact docs -->
   - [ ] `doc-complete` <!-- Docs have been already added -->
   
   ### Matching PR in forked repository
   
   PR in forked repository: https://github.com/lhotari/pulsar/pull/100
   
   <!--
   After opening this PR, the build in apache/pulsar will fail and instructions will
   be provided for opening a PR in the PR author's forked repository.
   
   apache/pulsar pull requests should be first tested in your own fork since the 
   apache/pulsar CI based on GitHub Actions has constrained resources and quota.
   GitHub Actions provides separate quota for pull requests that are executed in 
   a forked repository.
   
   The tests will be run in the forked repository until all PR review comments have
   been handled, the tests pass and the PR is approved by a reviewer.
   -->


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [pulsar] codelipenghui closed pull request #17943: [improve][CI] Speed up execution of OTHER unit test group by removing -DtestReuseFork=false

Posted by GitBox <gi...@apache.org>.
codelipenghui closed pull request #17943: [improve][CI] Speed up execution of OTHER unit test group by removing -DtestReuseFork=false
URL: https://github.com/apache/pulsar/pull/17943


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [pulsar] poorbarcode commented on pull request #17943: [improve][CI] Speed up execution of OTHER unit test group by removing -DtestReuseFork=false

Posted by GitBox <gi...@apache.org>.
poorbarcode commented on PR #17943:
URL: https://github.com/apache/pulsar/pull/17943#issuecomment-1299562110

   /pulsarbot rerun-failure-checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [pulsar] Technoboy- merged pull request #17943: [improve][ci] Speed up execution of OTHER unit test group by removing -DtestReuseFork=false

Posted by GitBox <gi...@apache.org>.
Technoboy- merged PR #17943:
URL: https://github.com/apache/pulsar/pull/17943


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [pulsar] codecov-commenter commented on pull request #17943: [improve][ci] Speed up execution of OTHER unit test group by removing -DtestReuseFork=false

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #17943:
URL: https://github.com/apache/pulsar/pull/17943#issuecomment-1320803631

   # [Codecov](https://codecov.io/gh/apache/pulsar/pull/17943?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > :exclamation: No coverage uploaded for pull request base (`master@4742b6f`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#section-missing-base-commit).
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/pulsar/pull/17943/graphs/tree.svg?width=650&height=150&src=pr&token=acYqCpsK9J&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/pulsar/pull/17943?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@            Coverage Diff            @@
   ##             master   #17943   +/-   ##
   =========================================
     Coverage          ?   37.11%           
     Complexity        ?     1968           
   =========================================
     Files             ?      209           
     Lines             ?    14393           
     Branches          ?     1569           
   =========================================
     Hits              ?     5342           
     Misses            ?     8469           
     Partials          ?      582           
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | unittests | `37.11% <0.00%> (?)` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [pulsar] Technoboy- closed pull request #17943: [improve][CI] Speed up execution of OTHER unit test group by removing -DtestReuseFork=false

Posted by GitBox <gi...@apache.org>.
Technoboy- closed pull request #17943: [improve][CI] Speed up execution of OTHER unit test group by removing -DtestReuseFork=false
URL: https://github.com/apache/pulsar/pull/17943


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org