You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@yunikorn.apache.org by GitBox <gi...@apache.org> on 2022/03/17 06:53:41 UTC

[GitHub] [incubator-yunikorn-web] akhilpb001 commented on a change in pull request #71: [YUNIKORN-1105] Use bytes as base unit for memory

akhilpb001 commented on a change in pull request #71:
URL: https://github.com/apache/incubator-yunikorn-web/pull/71#discussion_r828802939



##########
File path: src/app/utils/common.util.ts
##########
@@ -30,9 +30,19 @@ export class CommonUtil {
   }
 
   static formatMemory(value: number | string): string {
-    let unit = 'MB';
+    let unit = 'bytes';

Review comment:
       nit: Would it be better to the casing of `bytes` to `Bytes`?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org