[GitHub] [incubator-druid] jihoonson opened a new pull request #8905: Retrying with a backward compatible task type on unknown task type error in parallel indexing

[GitBox <gi...@apache.org>]

jihoonson opened a new pull request #8905: Retrying with a backward compatible task type on unknown task type error in parallel indexing
URL: https://github.com/apache/incubator-druid/pull/8905
 
 
   Fixes https://github.com/apache/incubator-druid/issues/8836.
   
   ### Description
   
   I think I don't like this patch much, but don't see a better solution. Please leave comments if anyone has a better idea.
   
   `TaskMonitor.submit()` creates a sub task for a given spec submits it to the overlord. Here, if the task type was unknown to the overlord (can happen during a rolling update), the overlord would return an HTTP error to `TaskMonitor`. `HttpIndexingServiceClient` would throw an `IllegalStateException` if the HTTP response was not 200.
   
   To handle this, I added a new method `SubTaskSpec.newSubTaskWithBackwardCompatibleType()` which will be called if `SubTaskSpec.newSubTask()` fails with an `IllegalStateExceptoin` with a message starting with "Could not resolve type id". 
   
   <hr>
   
   This PR has:
   - [x] been self-reviewed.
      - [ ] using the [concurrency checklist](https://github.com/apache/incubator-druid/blob/master/dev/code-review/concurrency.md) (Remove this item if the PR doesn't have any relation to concurrency.)
   - [ ] added documentation for new or modified features or behaviors.
   - [x] added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
   - [ ] added or updated version, license, or notice information in [licenses.yaml](https://github.com/apache/incubator-druid/blob/master/licenses.yaml)
   - [ ] added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
   - [x] added unit tests or modified existing tests to cover new code paths.
   - [ ] added integration tests.
   - [ ] been tested in a test Druid cluster.
   
   <!-- Check the items by putting "x" in the brackets for the done things. Not all of these items apply to every PR. Remove the items which are not done or not relevant to the PR. None of the items from the checklist above are strictly necessary, but it would be very helpful if you at least self-review the PR. -->
   
   <hr>
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org