You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/10/11 03:28:58 UTC

[GitHub] [pulsar] dragonls commented on pull request #17986: [fix][broker][branch-2.9] Fix system topic schema not compatible bug

dragonls commented on PR #17986:
URL: https://github.com/apache/pulsar/pull/17986#issuecomment-1274039584

   > Nice catch!
   > 
   > The change looks good.
   > 
   > I try to understand why the `setSchemaCompatibilityStrategy` is not been called and why it is related to #13557
   > 
   > It looks like we will go to here https://github.com/apache/pulsar/blob/branch-2.9/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentTopic.java#L339-L343 which cause missed the `setSchemaCompatibilityStrategy`?
   
   As for why the `setSchemaCompatibilityStrategy` is not been called, I'm also not quite sure, because the test case `org.apache.pulsar.broker.systopic.NamespaceEventsSystemTopicServiceTest#testSchemaCompatibility` passed.
   https://github.com/apache/pulsar/blob/4abd4d23e8ab498e0c72c4e062063d6409f66da9/pulsar-broker/src/test/java/org/apache/pulsar/broker/systopic/NamespaceEventsSystemTopicServiceTest.java#L75-L91
   
   
   After #13557  merged, the system topic schema has been changed, see:
   ![image](https://user-images.githubusercontent.com/2565118/194989939-155828c1-be70-4cf2-87d7-416b94232c75.png)
   
   And before this bugfix, `schemaCompatibilityStrategy` is `SchemaCompatibilityStrategy.FULL` if `setSchemaCompatibilityStrategy` is not been called, which cause the schema not compatible error.
   
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org