You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/12/22 17:01:37 UTC
[GitHub] [arrow] Dandandan opened a new pull request #8991: ARROW-11008: [Rust][DataFusion] Simplify count accumulator
Dandandan opened a new pull request #8991:
URL: https://github.com/apache/arrow/pull/8991
This just simplifies the code to directly use `u64` instead of `ScalarValue`, simplifying some functions.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] alamb closed pull request #8991: ARROW-11008: [Rust][DataFusion] Simplify count accumulator
Posted by GitBox <gi...@apache.org>.
alamb closed pull request #8991:
URL: https://github.com/apache/arrow/pull/8991
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #8991: ARROW-11008: [Rust][DataFusion] Simplify count accumulator
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #8991:
URL: https://github.com/apache/arrow/pull/8991#issuecomment-749673791
https://issues.apache.org/jira/browse/ARROW-11008
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] codecov-io commented on pull request #8991: ARROW-11008: [Rust][DataFusion] Simplify count accumulator
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #8991:
URL: https://github.com/apache/arrow/pull/8991#issuecomment-749675212
# [Codecov](https://codecov.io/gh/apache/arrow/pull/8991?src=pr&el=h1) Report
> Merging [#8991](https://codecov.io/gh/apache/arrow/pull/8991?src=pr&el=desc) (ac1104c) into [master](https://codecov.io/gh/apache/arrow/commit/0519c4c0ecccd7d84ce44bd3a3e7bcb4fef8f4d6?el=desc) (0519c4c) will **increase** coverage by `0.01%`.
> The diff coverage is `71.42%`.
[](https://codecov.io/gh/apache/arrow/pull/8991?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #8991 +/- ##
==========================================
+ Coverage 82.64% 82.65% +0.01%
==========================================
Files 200 200
Lines 49730 49716 -14
==========================================
- Hits 41098 41093 -5
+ Misses 8632 8623 -9
```
| [Impacted Files](https://codecov.io/gh/apache/arrow/pull/8991?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [rust/datafusion/src/physical\_plan/expressions.rs](https://codecov.io/gh/apache/arrow/pull/8991/diff?src=pr&el=tree#diff-cnVzdC9kYXRhZnVzaW9uL3NyYy9waHlzaWNhbF9wbGFuL2V4cHJlc3Npb25zLnJz) | `84.58% <71.42%> (+0.40%)` | :arrow_up: |
| [rust/parquet/src/encodings/encoding.rs](https://codecov.io/gh/apache/arrow/pull/8991/diff?src=pr&el=tree#diff-cnVzdC9wYXJxdWV0L3NyYy9lbmNvZGluZ3MvZW5jb2RpbmcucnM=) | `95.43% <0.00%> (+0.19%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/arrow/pull/8991?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/arrow/pull/8991?src=pr&el=footer). Last update [0519c4c...0cc5b00](https://codecov.io/gh/apache/arrow/pull/8991?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org