You are viewing a plain text version of this content. The canonical link for it is here.
Posted to solr-dev@lucene.apache.org by "Coda Hale (JIRA)" <ji...@apache.org> on 2007/02/02 00:40:05 UTC

[jira] Created: (SOLR-134) Handle Time values in fields correctly (UTC + ISO 8601)

Handle Time values in fields correctly (UTC + ISO 8601)
-------------------------------------------------------

                 Key: SOLR-134
                 URL: https://issues.apache.org/jira/browse/SOLR-134
             Project: Solr
          Issue Type: Improvement
          Components: clients - ruby - flare
            Reporter: Coda Hale


Here's a patch for automatically converting Time objects in fields to the UTC/ISO 8601 format that Solr can parse.

Which means this will work:

  connection.add(:id => 1, :created_at => Time.now)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (SOLR-134) Handle Time values in fields correctly (UTC + ISO 8601)

Posted by "Erik Hatcher (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SOLR-134?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Erik Hatcher resolved SOLR-134.
-------------------------------

    Resolution: Fixed
      Assignee: Erik Hatcher

thank goodness not everyone lives on the west coast, it would have tipped off into the ocean by now.

thanks for your patch... applied and commited.

> Handle Time values in fields correctly (UTC + ISO 8601)
> -------------------------------------------------------
>
>                 Key: SOLR-134
>                 URL: https://issues.apache.org/jira/browse/SOLR-134
>             Project: Solr
>          Issue Type: Improvement
>          Components: clients - ruby - flare
>            Reporter: Coda Hale
>         Assigned To: Erik Hatcher
>         Attachments: solrb_xml_time.diff, solrb_xml_time_with_better_tests.diff
>
>
> Here's a patch for automatically converting Time objects in fields to the UTC/ISO 8601 format that Solr can parse.
> Which means this will work:
>   connection.add(:id => 1, :created_at => Time.now)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (SOLR-134) Handle Time values in fields correctly (UTC + ISO 8601)

Posted by "Erik Hatcher (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/SOLR-134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12469643 ] 

Erik Hatcher commented on SOLR-134:
-----------------------------------

  1) Failure:
test_xml_date(FieldTest) [./test/unit/field_test.rb:27]:
<"<field name='what_time_should_we_party_as_if_it_is'>1999-12-31T08:00:00Z</field>"> expected but was
<"<field name='what_time_should_we_party_as_if_it_is'>1999-12-31T05:00:00Z</field>">.

I'm cool with this sort of patch though, so once we get the test working, consider it committed.

> Handle Time values in fields correctly (UTC + ISO 8601)
> -------------------------------------------------------
>
>                 Key: SOLR-134
>                 URL: https://issues.apache.org/jira/browse/SOLR-134
>             Project: Solr
>          Issue Type: Improvement
>          Components: clients - ruby - flare
>            Reporter: Coda Hale
>         Attachments: solrb_xml_time.diff
>
>
> Here's a patch for automatically converting Time objects in fields to the UTC/ISO 8601 format that Solr can parse.
> Which means this will work:
>   connection.add(:id => 1, :created_at => Time.now)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (SOLR-134) Handle Time values in fields correctly (UTC + ISO 8601)

Posted by "Erik Hatcher (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/SOLR-134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12469644 ] 

Erik Hatcher commented on SOLR-134:
-----------------------------------

Do also note that Solr can tackle date math in its own configuration:  http://www.mail-archive.com/solr-user@lucene.apache.org/msg01563.html  - though I agree that if we're handing a Time or Date to Solr that it does the most responsible thing it can with it, as shown in your patch.

> Handle Time values in fields correctly (UTC + ISO 8601)
> -------------------------------------------------------
>
>                 Key: SOLR-134
>                 URL: https://issues.apache.org/jira/browse/SOLR-134
>             Project: Solr
>          Issue Type: Improvement
>          Components: clients - ruby - flare
>            Reporter: Coda Hale
>         Attachments: solrb_xml_time.diff
>
>
> Here's a patch for automatically converting Time objects in fields to the UTC/ISO 8601 format that Solr can parse.
> Which means this will work:
>   connection.add(:id => 1, :created_at => Time.now)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (SOLR-134) Handle Time values in fields correctly (UTC + ISO 8601)

Posted by "Coda Hale (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SOLR-134?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Coda Hale updated SOLR-134:
---------------------------

    Attachment: solrb_xml_time_with_better_tests.diff

What, you mean not everyone is on the West Coast?

> Handle Time values in fields correctly (UTC + ISO 8601)
> -------------------------------------------------------
>
>                 Key: SOLR-134
>                 URL: https://issues.apache.org/jira/browse/SOLR-134
>             Project: Solr
>          Issue Type: Improvement
>          Components: clients - ruby - flare
>            Reporter: Coda Hale
>         Attachments: solrb_xml_time.diff, solrb_xml_time_with_better_tests.diff
>
>
> Here's a patch for automatically converting Time objects in fields to the UTC/ISO 8601 format that Solr can parse.
> Which means this will work:
>   connection.add(:id => 1, :created_at => Time.now)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (SOLR-134) Handle Time values in fields correctly (UTC + ISO 8601)

Posted by "Coda Hale (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SOLR-134?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Coda Hale updated SOLR-134:
---------------------------

    Attachment: solrb_xml_time.diff

Includes unit test.

> Handle Time values in fields correctly (UTC + ISO 8601)
> -------------------------------------------------------
>
>                 Key: SOLR-134
>                 URL: https://issues.apache.org/jira/browse/SOLR-134
>             Project: Solr
>          Issue Type: Improvement
>          Components: clients - ruby - flare
>            Reporter: Coda Hale
>         Attachments: solrb_xml_time.diff
>
>
> Here's a patch for automatically converting Time objects in fields to the UTC/ISO 8601 format that Solr can parse.
> Which means this will work:
>   connection.add(:id => 1, :created_at => Time.now)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.