You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ambari.apache.org by "Hudson (JIRA)" <ji...@apache.org> on 2019/01/07 20:35:00 UTC
[jira] [Commented] (AMBARI-25061) Refactor AddServiceInfo to use a
builder
[ https://issues.apache.org/jira/browse/AMBARI-25061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16736312#comment-16736312 ]
Hudson commented on AMBARI-25061:
---------------------------------
SUCCESS: Integrated in Jenkins build Ambari-trunk-Commit #10414 (See [https://builds.apache.org/job/Ambari-trunk-Commit/10414/])
AMBARI-25061. Refactor AddServiceInfo to use a builder (#2756) (github: [https://gitbox.apache.org/repos/asf?p=ambari.git&a=commit&h=883d95f7a93ed53e637b617acd86cd2bf9b5c3fd])
* (edit) ambari-server/src/main/java/org/apache/ambari/server/topology/addservice/RequestValidator.java
* (edit) ambari-server/src/test/java/org/apache/ambari/server/topology/addservice/ProvisionActionPredicateBuilderTest.java
* (edit) ambari-server/src/test/java/org/apache/ambari/server/topology/addservice/StackAdvisorAdapterTest.java
* (edit) ambari-server/src/main/java/org/apache/ambari/server/topology/addservice/AddServiceInfo.java
> Refactor AddServiceInfo to use a builder
> ----------------------------------------
>
> Key: AMBARI-25061
> URL: https://issues.apache.org/jira/browse/AMBARI-25061
> Project: Ambari
> Issue Type: Improvement
> Components: ambari-server
> Affects Versions: 2.8.0
> Reporter: Doroszlai, Attila
> Assignee: Doroszlai, Attila
> Priority: Major
> Labels: pull-request-available
> Fix For: 2.8.0
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> {{AddServiceInfo}} constructor could be improved by the Builder pattern.
> https://github.com/apache/ambari/blob/1431ab44887c2ff7f9e94f8fcb42e24e3ce33800/ambari-server/src/main/java/org/apache/ambari/server/topology/addservice/AddServiceInfo.java#L45-L83
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)