You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by GitBox <gi...@apache.org> on 2020/04/20 02:52:32 UTC

[GitHub] [kafka] ijuma opened a new pull request #8519: MINOR: Upgrade gradle plugins and test libraries for Java 14 support

ijuma opened a new pull request #8519:
URL: https://github.com/apache/kafka/pull/8519


   Also remove deprecated `=` in resolutionStrategy.
   
   With these changes, the build works with Java 14 and Scala 2.12. The
   same will apply to Scala 2.13 when Scala 2.13.2 is released (should
   happen within 1-2 weeks).
   
   ### Committer Checklist (excluded from commit message)
   - [ ] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] ijuma commented on issue #8519: MINOR: Upgrade gradle plugins and test libraries for Java 14 support

Posted by GitBox <gi...@apache.org>.
ijuma commented on issue #8519:
URL: https://github.com/apache/kafka/pull/8519#issuecomment-616531362


   retest this please


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] ijuma commented on issue #8519: MINOR: Upgrade gradle plugins and test libraries for Java 14 support

Posted by GitBox <gi...@apache.org>.
ijuma commented on issue #8519:
URL: https://github.com/apache/kafka/pull/8519#issuecomment-616802690


   2 flaky tests, one in each job:
   * org.apache.kafka.streams.integration.EOSUncleanShutdownIntegrationTest.shouldWorkWithUncleanShutdownWipeOutStateStore[exactly_once_beta]
   * kafka.integration.MetricsDuringTopicCreationDeletionTest.testMetricsDuringTopicCreateDelete


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] mjsax commented on a change in pull request #8519: MINOR: Upgrade gradle plugins and test libraries for Java 14 support

Posted by GitBox <gi...@apache.org>.
mjsax commented on a change in pull request #8519:
URL: https://github.com/apache/kafka/pull/8519#discussion_r411639992



##########
File path: jenkins.sh
##########
@@ -29,12 +29,17 @@
     --profile --no-daemon --continue -PtestLoggingEvents=started,passed,skipped,failed "$@" \
     || { echo 'Test steps failed'; exit 1; }
 
-# Verify that Kafka Streams archetype compiles
 if [ $JAVA_HOME = "/home/jenkins/tools/java/latest11" ] ; then
   echo "Skipping Kafka Streams archetype test for Java 11"
   exit 0
 fi
 
+if [ $JAVA_HOME = "/home/jenkins/tools/java/latest14" ] ; then
+  echo "Skipping Kafka Streams archetype test for Java 14"
+  exit 0
+fi

Review comment:
       LGTM




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org