You are viewing a plain text version of this content. The canonical link for it is here.
Posted to cvs@httpd.apache.org by be...@hyperreal.org on 1997/12/07 22:28:49 UTC
cvs commit: apachen/src/main alloc.c
ben 97/12/07 13:28:49
Modified: src CHANGES
src/main alloc.c
Log:
Cure filehandle leak in Win32 CGI.
PR: 1523
Submitted by: Peter Tillemans <pt...@net4all.be>
Revision Changes Path
1.523 +2 -0 apachen/src/CHANGES
Index: CHANGES
===================================================================
RCS file: /export/home/cvs/apachen/src/CHANGES,v
retrieving revision 1.522
retrieving revision 1.523
diff -u -r1.522 -r1.523
--- CHANGES 1997/11/25 22:00:40 1.522
+++ CHANGES 1997/12/07 21:28:46 1.523
@@ -1,5 +1,7 @@
Changes with Apache 1.3b4
+ *) WIN32: Cure file leak in CGIs. [Peter Tillemans <pt...@net4all.be>] PR#1523
+
*) proxy_ftp: the directory listings generated by the proxy ftp module
now have a title in which the path components are clickable and allow
quick navigation to the clicked-on directory on the currently listed
1.59 +9 -0 apachen/src/main/alloc.c
Index: alloc.c
===================================================================
RCS file: /export/home/cvs/apachen/src/main/alloc.c,v
retrieving revision 1.58
retrieving revision 1.59
diff -u -r1.58 -r1.59
--- alloc.c 1997/11/12 23:22:05 1.58
+++ alloc.c 1997/12/07 21:28:48 1.59
@@ -1318,11 +1318,20 @@
/* restore the original stdin, stdout and stderr */
if (pipe_in)
+ {
dup2(hStdIn, fileno(stdin));
+ close(hStdIn);
+ }
if (pipe_out)
+ {
dup2(hStdOut, fileno(stdout));
+ close(hStdOut);
+ }
if (pipe_err)
+ {
dup2(hStdErr, fileno(stderr));
+ close(hStdErr);
+ }
if (pid) {
note_subprocess(p, pid, kill_how);
Re: cvs commit: apachen/src/main alloc.c
Posted by Ben Laurie <be...@algroup.co.uk>.
Marc Slemko wrote:
>
> On 7 Dec 1997 ben@hyperreal.org wrote:
>
> > ben 97/12/07 13:28:49
> >
> > Modified: src CHANGES
> > src/main alloc.c
> > Log:
> > Cure filehandle leak in Win32 CGI.
> > PR: 1523
> > Submitted by: Peter Tillemans <pt...@net4all.be>
> >
> > Revision Changes Path
> > 1.523 +2 -0 apachen/src/CHANGES
> >
>
> I think there are another couple of PRs complaining about this
> somewhere. They should be closed too.
If there are, then they haven't been classified as os-windows...
Cheers,
Ben.
--
Ben Laurie |Phone: +44 (181) 735 0686|Apache Group member
Freelance Consultant |Fax: +44 (181) 735 0689|http://www.apache.org
and Technical Director|Email: ben@algroup.co.uk |Apache-SSL author
A.L. Digital Ltd, |http://www.algroup.co.uk/Apache-SSL
London, England. |"Apache: TDG" http://www.ora.com/catalog/apache
Re: cvs commit: apachen/src/main alloc.c
Posted by Marc Slemko <ma...@worldgate.com>.
On 7 Dec 1997 ben@hyperreal.org wrote:
> ben 97/12/07 13:28:49
>
> Modified: src CHANGES
> src/main alloc.c
> Log:
> Cure filehandle leak in Win32 CGI.
> PR: 1523
> Submitted by: Peter Tillemans <pt...@net4all.be>
>
> Revision Changes Path
> 1.523 +2 -0 apachen/src/CHANGES
>
I think there are another couple of PRs complaining about this
somewhere. They should be closed too.
I, however, am another one of those odd people studying for finals.
Re: cvs commit: apachen/src/main alloc.c
Posted by Marc Slemko <ma...@worldgate.com>.
On 7 Dec 1997 ben@hyperreal.org wrote:
> ben 97/12/07 13:28:49
>
> Modified: src CHANGES
> src/main alloc.c
> Log:
> Cure filehandle leak in Win32 CGI.
> PR: 1523
> Submitted by: Peter Tillemans <pt...@net4all.be>
>
> Revision Changes Path
> 1.523 +2 -0 apachen/src/CHANGES
>
I think there are another couple of PRs complaining about this
somewhere. They should be closed too.
I, however, am another one of those odd people studying for finals.