[jira] [Commented] (ARROW-6514) [Developer][C++][CMake] LLVM tools are restricted to the exact version 7.0

["Antoine Pitrou (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ARROW-6514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16926701#comment-16926701 ] 

Antoine Pitrou commented on ARROW-6514:
---------------------------------------

It's important to use the hard-coded one, otherwise you will get different answers locally and on CI.

> [Developer][C++][CMake] LLVM tools are restricted to the exact version 7.0
> --------------------------------------------------------------------------
>
>                 Key: ARROW-6514
>                 URL: https://issues.apache.org/jira/browse/ARROW-6514
>             Project: Apache Arrow
>          Issue Type: Improvement
>          Components: C++
>            Reporter: Krisztian Szucs
>            Priority: Major
>
> I have LLVM 7.1 installed locally, and FindClangTools couldn't locate it because ARROW_LLVM_VERSION is [hardcoded to 7.0|https://github.com/apache/arrow/blob/3f2a33f902983c0d395e0480e8a8df40ed5da29c/cpp/CMakeLists.txt#L91-L99] and clang tools is [restricted to the minor version|https://github.com/apache/arrow/blob/3f2a33f902983c0d395e0480e8a8df40ed5da29c/cpp/cmake_modules/FindClangTools.cmake#L78].
> If it makes sense to restrict clang tools location down to the minor version, then we need to pass the located LLVM's version instead of the hardcoded one.



--
This message was sent by Atlassian Jira
(v8.3.2#803003)